Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar size does not accept units other than pixels #3543

Closed
lucianosb opened this issue Jun 5, 2019 · 0 comments · Fixed by #3583
Closed

Avatar size does not accept units other than pixels #3543

lucianosb opened this issue Jun 5, 2019 · 0 comments · Fixed by #3583
Assignees
@cipchk
Labels
Component: Avatar

Comments

@lucianosb
Copy link

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-avatar-customsize

Steps to reproduce

Use a string input in nzSize such as

[nzSize]="'9.38vw'"

What is expected?

For the component to use the desired unit

What is actually happening?

The component does not parse a string and can only accept numeric values to input as size in pixels.

Environment Info
ng-zorro-antd 7.5.0
Browser Chrome 74

This would be important to ensure a responsive size for the avatar by using VW as a unit.
@weekly-digest weekly-digest bot mentioned this issue Jun 9, 2019
Closed
@vthinkxie vthinkxie assigned cipchk and unassigned hsuanxyz Jun 14, 2019
@cipchk cipchk mentioned this issue Jun 16, 2019
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Jun 21, 2019
@cipchk @vthinkxie
feat(module:avatar): add nzSrcSet & nzAlt properites (#3583)
d0ad5e8 
* feat(module:avatar): add nzSrcSet & nzAlt properites
- support custom unit in image avatar, close #3543

* chore: add docs
@weekly-digest weekly-digest bot mentioned this issue Jun 23, 2019
Closed
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@cipchk @Ricbet
feat(module:avatar): add nzSrcSet & nzAlt properites (NG-ZORRO#3583)
7ac0563 
* feat(module:avatar): add nzSrcSet & nzAlt properites
- support custom unit in image avatar, close NG-ZORRO#3543

* chore: add docs
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@cipchk @vthinkxie
feat(module:avatar): add nzSrcSet & nzAlt properites (NG-ZORRO#3583)
d3d3874 
* feat(module:avatar): add nzSrcSet & nzAlt properites
- support custom unit in image avatar, close NG-ZORRO#3543

* chore: add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cipchk cipchk

Labels
Component: Avatar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(module:avatar): add nzSrcSet & nzAlt properites
4 participants
@lucianosb @vthinkxie @cipchk @hsuanxyz