Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nz-drawer: close button is visible though nzVisible is false #4304

Closed
timadevelop opened this issue Oct 16, 2019 · 1 comment · Fixed by #4311
Closed

nz-drawer: close button is visible though nzVisible is false #4304

timadevelop opened this issue Oct 16, 2019 · 1 comment · Fixed by #4311
Assignees
@hsuanxyz
Labels
Component: Drawer

Comments

@timadevelop
Copy link

timadevelop commented Oct 16, 2019 •
edited
Loading

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-nz-drawer-close-btn-bug

Steps to reproduce

  • Use nz-drawer

What is expected?

  • Hidden close button when nzVisible is false

What is actually happening?

  • The close button is always visible
Environment Info
ng-zorro-antd 8.4.0
Browser Chrome 77.0

Here's a simple fix:

.ant-drawer-wrapper-body {
  // ....
  position: relative;
}
timadevelop added a commit to timadevelop/servicescope-web-client that referenced this issue Oct 16, 2019
@timadevelop
ng-zorro nz-drawer close btn temporary fix (ref NG-ZORRO/ng-zorro-ant…
418903b 
…d#4304)
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Oct 17, 2019
@hsuanxyz
fix(module:drawer): fix the HTML structure of the drawer header
206b23d 
close NG-ZORRO#4304
@hsuanxyz
Copy link
Member

Thank your issue, we didn't synchronize the HTML structure, it caused unexpected styles. We will fixed it when next version.

@hsuanxyz hsuanxyz mentioned this issue Oct 17, 2019
Merged
3 tasks
@weekly-digest weekly-digest bot mentioned this issue Oct 20, 2019
Closed
vthinkxie pushed a commit that referenced this issue Oct 23, 2019
@hsuanxyz @vthinkxie
fix(module:drawer): fix the HTML structure of the drawer header (#4311)
5cdd5db 
* fix(module:drawer): fix the HTML structure of the drawer header

close #4304

* fix(module:drawer): fix the template conditions

* test(module:drawer): fix test

* fix(module:drawer): fix the template conditions
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@hsuanxyz @Ricbet
fix(module:drawer): fix the HTML structure of the drawer header (NG-Z…
60f6508 
…ORRO#4311)

* fix(module:drawer): fix the HTML structure of the drawer header

close NG-ZORRO#4304

* fix(module:drawer): fix the template conditions

* test(module:drawer): fix test

* fix(module:drawer): fix the template conditions
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
Closed
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz @vthinkxie
fix(module:drawer): fix the HTML structure of the drawer header (NG-Z…
5773aec 
…ORRO#4311)

* fix(module:drawer): fix the HTML structure of the drawer header

close NG-ZORRO#4304

* fix(module:drawer): fix the template conditions

* test(module:drawer): fix test

* fix(module:drawer): fix the template conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
Component: Drawer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:drawer): fix the HTML structure of the drawer header hsuanxyz/ng-zorro-antd
3 participants
@vthinkxie @timadevelop @hsuanxyz