Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

通知提醒框全局配置在生产环境中不生效 #4319

Closed
tazyong opened this issue Oct 19, 2019 · 3 comments · Fixed by #4325
Closed

通知提醒框全局配置在生产环境中不生效 #4319

tazyong opened this issue Oct 19, 2019 · 3 comments · Fixed by #4325
Assignees
@wzhudev
Labels
🐛 Bug

Comments

@tazyong
Copy link

tazyong commented Oct 19, 2019

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-19p5nt

Steps to reproduce

任何时候必现

What is expected?

在生产环境里，根据自定义配置正确显示通知提醒框。

What is actually happening?

全局配置了通知提醒框在右下角显示，在开发环境正常，但在生产环境依然显示在左上角。

Environment Info
ng-zorro-antd 8.4.0
Browser 77.0.3865.120
@zorro-bot
Copy link

zorro-bot bot commented Oct 19, 2019

Translation of this issue:

Notification balloon global configuration does not take effect in the production environment

Reproduction link

Https://stackblitz.com/edit/ng-zorro-antd-start-19p5nt

Steps to reproduce

Any time must now

What is expected?

In a production environment, the custom configuration according to the correct display of the notification balloon.

What is actually happening?

Global Configuration the notification balloon in the lower right corner shows that in normal development environment, but in a production environment is still displayed in the upper left corner.

Environment Info
Ng-zorro-antd 8.4.0
Browser 77.0.3865.120

@wzhudev wzhudev self-assigned this Oct 20, 2019
@wzhudev
Copy link
Member

wzhudev commented Oct 20, 2019 •
edited
Loading

@tazyong Thanks for reporting this. It looks that after compiling our code breaks:

Dev:

Snipaste_2019-10-20_10-04-34

Prod:

Snipaste_2019-10-20_10-01-42

We will fix this soon. For now you can provide a NZ_NOTIFICATION_CONFIG.

@wzhudev
Copy link
Member

wzhudev commented Oct 20, 2019 •
edited
Loading

@tazyong Have you tried other config?

It looks that all globally-configurable properties break...

@wzhudev wzhudev mentioned this issue Oct 20, 2019
Merged
3 tasks
@weekly-digest weekly-digest bot mentioned this issue Oct 20, 2019
Closed
vthinkxie pushed a commit that referenced this issue Oct 23, 2019
@vthinkxie
fix(module:core): fix global config not working in prod mode (#4325)
cc9308d 
* fix(module:core): fix global config not working in prod mode

* chore: cleanup code
close #4319
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
fix(module:core): fix global config not working in prod mode (NG-ZORR…
637cd7a 
…O#4325)

* fix(module:core): fix global config not working in prod mode

* chore: cleanup code
close NG-ZORRO#4319
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
fix(module:core): fix global config not working in prod mode (NG-ZORR…
8789618 
…O#4325)

* fix(module:core): fix global config not working in prod mode

* chore: cleanup code
close NG-ZORRO#4319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:core): fix global config not working in prod mode wzhudev/ng-zorro-antd
2 participants
@wzhudev @tazyong