Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:cascader): refactor cascader #1140

Merged
merged 4 commits into from
Mar 15, 2018
Merged

refactor(module:cascader): refactor cascader #1140

merged 4 commits into from
Mar 15, 2018

Conversation

fbchen
Copy link
Contributor

@fbchen fbchen commented Mar 14, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #399 #422

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #1140 into 0.7.0 will decrease coverage by 0.52%.
The diff coverage is 96.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##            0.7.0    #1140      +/-   ##
==========================================
- Coverage   98.01%   97.48%   -0.53%     
==========================================
  Files         146      181      +35     
  Lines        5479     7089    +1610     
  Branches      663      913     +250     
==========================================
+ Hits         5370     6911    +1541     
- Misses          0       18      +18     
- Partials      109      160      +51
Impacted Files Coverage Δ
components/cascader/nz-cascader.module.ts 100% <100%> (ø)
components/cascader/nz-cascader.component.ts 96.79% <96.79%> (ø)
components/message/nz-message.module.ts 100% <0%> (ø)
components/tooltip/nz-tooltip.directive.ts 90% <0%> (ø)
components/popover/nz-popover.module.ts 100% <0%> (ø)
components/tooltip/nz-tooltip.module.ts 100% <0%> (ø)
components/slider/nz-slider-step.component.ts 91.66% <0%> (ø)
.../auto-complete/nz-autocomplete-option.component.ts 95.55% <0%> (ø)
components/auto-complete/index.ts 100% <0%> (ø)
...auto-complete/nz-autocomplete-trigger.directive.ts 96.47% <0%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cdf0a2...c17a8cf. Read the comment docs.

@vthinkxie vthinkxie merged commit c30c851 into NG-ZORRO:0.7.0 Mar 15, 2018
@fbchen fbchen deleted the 0.7.0-cascader branch March 16, 2018 04:53
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* refactor(module:cascader): refactor cascader

* refactor(module:cascader): refactor cascader

* refactor(module:cascader): refactor cascader

* refactor(module:cascader): refactor cascader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants