Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:time-picker): support null value in time-picker-panel #1388

Merged
merged 1 commit into from
May 1, 2018
Merged

feat(module:time-picker): support null value in time-picker-panel #1388

merged 1 commit into from
May 1, 2018

Conversation

vthinkxie
Copy link
Member

@vthinkxie vthinkxie commented May 1, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #1388 into master will decrease coverage by 0.1%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   97.04%   96.94%   -0.11%     
==========================================
  Files         196      196              
  Lines        8367     8370       +3     
  Branches     1106     1106              
==========================================
- Hits         8120     8114       -6     
- Misses         30       36       +6     
- Partials      217      220       +3
Impacted Files Coverage Δ
...ents/time-picker/nz-time-picker-panel.component.ts 84.39% <72%> (-1.47%) ⬇️
components/time-picker/nz-time-picker.component.ts 89.79% <80%> (-6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cb39e...a6b3902. Read the comment docs.

@vthinkxie vthinkxie merged commit 1ca1490 into NG-ZORRO:master May 1, 2018
@vthinkxie vthinkxie deleted the time-picker-null branch October 10, 2018 02:50
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant