Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:message): increase the overlay's zindex tobe the same with… #1461

Merged
merged 2 commits into from
May 22, 2018

Conversation

wilsoncook
Copy link
Member

… the inner original zindex style

close #1457

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1457

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #1461 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
+ Coverage   96.92%   96.92%   +<.01%     
==========================================
  Files         222      222              
  Lines        9493     9495       +2     
  Branches     1294     1294              
==========================================
+ Hits         9201     9203       +2     
  Misses         42       42              
  Partials      250      250
Impacted Files Coverage Δ
components/message/nz-message.service.ts 97.95% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f26ad...fb8429d. Read the comment docs.

@wilsoncook wilsoncook force-pushed the fix_modal_zindex branch 2 times, most recently from beadd89 to a4c1d97 Compare May 18, 2018 08:46
@vthinkxie vthinkxie self-requested a review May 22, 2018 02:31
@vthinkxie vthinkxie merged commit 5a51344 into NG-ZORRO:master May 22, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
NG-ZORRO#1461)

* fix(module:message): increase the overlay's zindex tobe the same with the inner original zindex style

close NG-ZORRO#1457

* test(module:message,time-picker): add more testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在0.7.0正式版下,打开modal框弹出Message全局提示会被modal框层叠
2 participants