-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:(module: date-picker): dd.MM.yyyy date format #1782
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1782 +/- ##
==========================================
- Coverage 97.34% 96.07% -1.28%
==========================================
Files 552 466 -86
Lines 11587 11174 -413
Branches 827 1462 +635
==========================================
- Hits 11279 10735 -544
+ Misses 195 126 -69
- Partials 113 313 +200
Continue to review full report at Codecov.
|
Hi @danielszenasi thanks for you pr! @wilsoncook please check this. |
Hi @danielszenasi , thanks for your efforts. |
Thanks for your response, i will try to provide a better solution later. |
I would prefer a interface with date time formatter with two functions: So everyone can use what the framework of own choice. |
@wilsoncook there is a reason for removing momentjs? I'm thinking about to fix this bug, and the faster way is to use momentjs. |
I am having similar issue, I am trying to implement: Did anyone find an easy work around or? |
Since there is no reply for a long time, this issue will be closed. Please contact us if you have any questions, thank you for your PR |
@irishwill2008 you mean something like that issue: #3491 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I want to use the date-picker with the following format [nzFormat]="'dd.MM.yyyy'", when I type the picker`s input, the state does not change, because the javascript date creates Wed Mar 07 2018 00:00:00 GMT+0100 (Central European Standard Time) from this string: "03.07.2018", so the day and mounth is not the correct order for the Date object.
Issue Number: N/A
What is the new behavior?
[nzFormat]="'dd.MM.yyyy'" works
Does this PR introduce a breaking change?
Other information