Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): resize content after window resized #1815

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 11, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1811

What is the new behavior?

The contents would be resized when window is resizing.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #1815 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1815      +/-   ##
==========================================
+ Coverage   96.07%   96.08%   +<.01%     
==========================================
  Files         466      466              
  Lines       11173    11175       +2     
  Branches     1461     1461              
==========================================
+ Hits        10735    10737       +2     
  Misses        126      126              
  Partials      312      312
Impacted Files Coverage Δ
components/carousel/nz-carousel.component.ts 96.69% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a6d09...362ec88. Read the comment docs.

@wzhudev wzhudev changed the title fix(carousel): resize content after window resized (#1811) fix(carousel): resize content after window resized Jul 12, 2018
@wzhudev wzhudev requested review from vthinkxie and hsuanxyz July 17, 2018 10:07
@vthinkxie vthinkxie merged commit 88b0915 into NG-ZORRO:master Jul 22, 2018
@wzhudev wzhudev deleted the fixcarousel branch July 22, 2018 07:55
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Jul 22, 2018
vthinkxie pushed a commit that referenced this pull request Jul 22, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants