Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:cascader): Add search #1873

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 24, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

User can search in Cascader now.

Issue Number: #1773

What is the new behavior?

User can search options by inputing.

Does this PR introduce a breaking change?

[] Yes
[x] No

Other information

@wzhudev wzhudev requested a review from vthinkxie July 24, 2018 05:34
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #1873 into master will increase coverage by 0.02%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1873      +/-   ##
=========================================
+ Coverage   95.97%     96%   +0.02%     
=========================================
  Files         466     466              
  Lines       11217   11286      +69     
  Branches     1474    1493      +19     
=========================================
+ Hits        10766   10835      +69     
  Misses        131     131              
  Partials      320     320
Impacted Files Coverage Δ
components/cascader/nz-cascader.component.ts 96.3% <97.22%> (+0.3%) ⬆️
components/tabs/nz-tabset.component.ts 96.58% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7a6cb...97a512d. Read the comment docs.

@wzhudev wzhudev requested a review from fbchen July 24, 2018 12:24
close NG-ZORRO#1773

fix toggle transition

fix lint

another solution with arrow support

fix lint

add test
@wzhudev wzhudev changed the title Add cascader search feat(module:cascader): Add search Jul 29, 2018
@vthinkxie vthinkxie merged commit 633bc87 into NG-ZORRO:master Aug 3, 2018
@wzhudev wzhudev deleted the cascader-search branch August 20, 2018 11:20
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants