Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:avatar): fix avatar text resize when used in list #2074

Closed
wants to merge 1 commit into from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 30, 2018

close #2005

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2005

What is the new behavior?

Avatar text would resize correctly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

When avatar is rendered in list, its DOM is not rendered before calcStringSize gets invoked. Need to write a test case for this?

@wzhudev wzhudev changed the title fix(module:avatar): fix avatar text resize when used in list [WIP] fix(module:avatar): fix avatar text resize when used in list Aug 31, 2018
@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #2074 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
+ Coverage   95.96%   95.96%   +<.01%     
==========================================
  Files         473      473              
  Lines       11516    11519       +3     
  Branches     1535     1535              
==========================================
+ Hits        11051    11054       +3     
  Misses        132      132              
  Partials      333      333
Impacted Files Coverage Δ
components/avatar/nz-avatar.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca1fdd...0e97472. Read the comment docs.

@wzhudev wzhudev requested a review from vthinkxie August 31, 2018 09:49
@wzhudev wzhudev changed the title [WIP] fix(module:avatar): fix avatar text resize when used in list fix(module:avatar): fix avatar text resize when used in list Aug 31, 2018
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsuanxyz
Copy link
Member

close via #2536

@hsuanxyz hsuanxyz closed this Dec 19, 2018
@wzhudev wzhudev deleted the avatar-in-list branch December 19, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar 组件 在 List 中使用, nzText 属性样式生效的和单独使用不一致
3 participants