feat(schematics): add fix icon schematic #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsuanxyz
force-pushed
the
schematics/fix-icon
branch
from
a41ecf1 to
71d6542
Compare
Codecov Report
@@ Coverage Diff @@
## master #2238 +/- ##
=========================================
Coverage ? 95.92%
=========================================
Files ? 485
Lines ? 12122
Branches ? 1621
=========================================
Hits ? 11628
Misses ? 139
Partials ? 355Continue to review full report at Codecov.
|
wzhudev
approved these changes
Oct 8, 2018
| @@ -27,7 +27,7 @@ timeline: true | |||
| * 支持多色图标。 | |||
| * 对于内建图标的更换可以提供更多 API，而不需要进行样式覆盖。 | |||
|
|
|||
| 我们尽可能地在不增加包体积的前提下对旧的 API 进行了兼容，你无需修改代码，但可能需要进行一些配置。关于 icon 的更多信息，请阅读 Icon API 的[“Svg 图标”](/components/icon/zh#svg-图标)和[“静态加载与动态加载”两节](/components/icon/zh#静态加载与动态加载)。 | |||
| 我们尽可能地在不增加包体积的前提下对旧的 API 进行了兼容，你无需修改代码，但可能需要进行一些配置。关于 icon 的更多信息，请阅读 Icon API 的[“Svg 图标”](/components/icon/zh#svg-图标)和[“静态加载与动态加载”](/components/icon/zh#静态加载与动态加载)两节。 | |||
|
Do we need to run this when user runs |
|
Will automatic run |
wzhudev
reviewed
Oct 9, 2018
components/icon/doc/index.en-US.md
Outdated
| @@ -7,6 +7,11 @@ hasPageDemo: true | |||
|
|
|||
| Semantic vector graphics. | |||
|
|
|||
| <blockquote style="border-color: orange;"> | |||
| <p><strong>If the icon cannot be displayed or the console has an error, Please run the following command to fix it <code>ng g ng-zorro-antd:fix-icon</code>.</strong></p> | |||
There was a problem hiding this comment.
The p in Please run should be lower case.
hsuanxyz
force-pushed
the
schematics/fix-icon
branch
from
71d6542 to
aee32d6
Compare
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2171
What is the new behavior?
Does this PR introduce a breaking change?
Other information