Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): fix object comparisons method #2328

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz requested a review from vthinkxie October 23, 2018 04:00
@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2328 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
- Coverage   95.88%   95.87%   -0.01%     
==========================================
  Files         485      485              
  Lines       12195    12195              
  Branches     1642     1642              
==========================================
- Hits        11693    11692       -1     
  Misses        146      146              
- Partials      356      357       +1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1dafc...48d187a. Read the comment docs.

@vthinkxie vthinkxie merged commit a7beda8 into NG-ZORRO:master Oct 23, 2018
@hsuanxyz hsuanxyz deleted the schematics/fix-fix-icon branch October 23, 2018 10:35
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants