Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): style error when the unit is percentage #2334

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2333

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2334 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
+ Coverage   95.85%   95.86%   +0.01%     
==========================================
  Files         485      485              
  Lines       12215    12224       +9     
  Branches     1647     1645       -2     
==========================================
+ Hits        11709    11719      +10     
  Misses        148      148              
+ Partials      358      357       -1
Impacted Files Coverage Δ
components/drawer/nz-drawer.component.ts 98.19% <100%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4ddfb...6a59a12. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the drawer/fix-percentagee branch from 8e79c34 to 4b9c9f4 Compare October 23, 2018 08:10
@hsuanxyz hsuanxyz force-pushed the drawer/fix-percentagee branch from 4b9c9f4 to 6a59a12 Compare October 23, 2018 08:17
@vthinkxie vthinkxie merged commit 9e07702 into NG-ZORRO:master Oct 23, 2018
@hsuanxyz hsuanxyz deleted the drawer/fix-percentagee branch October 29, 2018 04:11
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants