Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree): fix icon to svg & draggable event listener #2338

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

simplejason
Copy link
Member

@simplejason simplejason commented Oct 23, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2332 #2205 #2336

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@simplejason simplejason changed the title fix(module:tree): fix icon to svg & draggable event listener wip fix(module:tree): fix icon to svg & draggable event listener Oct 23, 2018
@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2338 into master will decrease coverage by 0.04%.
The diff coverage is 93.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2338      +/-   ##
==========================================
- Coverage   95.86%   95.82%   -0.05%     
==========================================
  Files         485      485              
  Lines       12241    12274      +33     
  Branches     1656     1666      +10     
==========================================
+ Hits        11735    11761      +26     
- Misses        149      152       +3     
- Partials      357      361       +4
Impacted Files Coverage Δ
components/tree/nz-tree-node.component.ts 95.3% <92.1%> (-1%) ⬇️
components/tree/nz-tree.component.ts 95.12% <94.44%> (-3.36%) ⬇️
components/tree/nz-tree.service.ts 94.07% <96.29%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06b9a7...96d05bd. Read the comment docs.

@simplejason simplejason changed the title wip fix(module:tree): fix icon to svg & draggable event listener WIP fix(module:tree): fix icon to svg & draggable event listener Oct 24, 2018
@simplejason simplejason changed the title WIP fix(module:tree): fix icon to svg & draggable event listener fix(module:tree): fix icon to svg & draggable event listener Oct 24, 2018
@simplejason simplejason force-pushed the zorro-fix branch 2 times, most recently from 3ffb9b0 to c6ca799 Compare October 25, 2018 12:11
@simplejason simplejason force-pushed the zorro-fix branch 2 times, most recently from 4a975ec to aadedbb Compare October 26, 2018 10:20
fix(module:tree): fix icon to svg & draggable event listener

fix(module:tree): fix spec

fix(module:tree): fix spec
@vthinkxie vthinkxie merged commit 8bc488e into NG-ZORRO:master Oct 26, 2018
@simplejason simplejason deleted the zorro-fix branch August 13, 2019 02:48
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants