Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:icon): add injectiontoken config and default twotone color #2353

Merged
merged 3 commits into from
Oct 26, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 25, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev requested review from vthinkxie and hsuanxyz October 25, 2018 04:14
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #2353 into master will increase coverage by 0.02%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
+ Coverage   95.86%   95.88%   +0.02%     
==========================================
  Files         485      485              
  Lines       12241    12253      +12     
  Branches     1656     1660       +4     
==========================================
+ Hits        11735    11749      +14     
+ Misses        149      148       -1     
+ Partials      357      356       -1
Impacted Files Coverage Δ
components/icon/nz-icon.service.ts 95.74% <92.85%> (-1.4%) ⬇️
components/time-picker/time-holder.ts 96.93% <0%> (+1.02%) ⬆️
components/table/nz-table.component.ts 96.66% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06b9a7...0b5a0b8. Read the comment docs.

@wzhudev wzhudev changed the title feat(module:icon): add injectiontoken config and default twotone color [WIP] feat(module:icon): add injectiontoken config and default twotone color Oct 25, 2018
@wzhudev wzhudev changed the title [WIP] feat(module:icon): add injectiontoken config and default twotone color feat(module:icon): add injectiontoken config and default twotone color Oct 26, 2018
docs: fix source

docs: add roadmap link in readme

fix(module:notification): fix custom icon demo

docs: fix navigation arrow
@wzhudev wzhudev force-pushed the icon-inject-token branch 2 times, most recently from 02a338a to 480e42e Compare October 26, 2018 09:19
@vthinkxie vthinkxie merged commit bea1d05 into NG-ZORRO:master Oct 26, 2018
@wzhudev wzhudev deleted the icon-inject-token branch November 5, 2018 02:56
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants