Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): add title property for select component #2409

Closed
wants to merge 1 commit into from

Conversation

tirelyl
Copy link
Contributor

@tirelyl tirelyl commented Nov 6, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1974

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #2409 into master will decrease coverage by <.01%.
The diff coverage is 96.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2409      +/-   ##
==========================================
- Coverage   95.85%   95.84%   -0.01%     
==========================================
  Files         485      487       +2     
  Lines       12299    12318      +19     
  Branches     1671     1663       -8     
==========================================
+ Hits        11789    11806      +17     
- Misses        150      152       +2     
  Partials      360      360
Impacted Files Coverage Δ
components/core/polyfill/match-media.ts 22.22% <0%> (-2.78%) ⬇️
components/tree/nz-tree.component.ts 95.12% <100%> (ø) ⬆️
components/modal/nz-modal.component.ts 95.74% <100%> (+0.42%) ⬆️
components/table/nz-td.component.ts 100% <100%> (ø) ⬆️
components/popconfirm/nz-popconfirm.component.ts 100% <100%> (ø) ⬆️
components/menu/nz-submenu.component.ts 95.45% <100%> (ø) ⬆️
components/tree/nz-tree-node.component.ts 95.3% <100%> (ø) ⬆️
components/card/nz-card-loading.component.ts 100% <100%> (ø) ⬆️
...te-picker/lib/popups/date-range-popup.component.ts 95.16% <100%> (-0.03%) ⬇️
components/grid/nz-row.component.ts 100% <100%> (ø) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb8548...9681251. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Nov 7, 2018

@tirelyl Please rebase to branch:next.

@tirelyl tirelyl changed the base branch from master to next November 8, 2018 03:45
@vthinkxie
Copy link
Member

HI @tirelyl , we are going to merge next to master now, plz submit this pr to master now, closed now.

@vthinkxie vthinkxie closed this Nov 30, 2018
@tirelyl tirelyl changed the base branch from next to master December 3, 2018 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants