-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:upload): support with non-image format file preview #2709
Conversation
- support download html attribute via linkProps
Deploy preview for ng-zorro-master ready! Built with commit ff9c326 |
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
=========================================
+ Coverage 95.57% 95.6% +0.03%
=========================================
Files 507 507
Lines 12086 12132 +46
Branches 1701 1713 +12
=========================================
+ Hits 11551 11599 +48
+ Misses 171 170 -1
+ Partials 364 363 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(module:upload): Compatible with non-image format file preview - support download html attribute via linkProps * chore: support hide preview button when is non-image url
…ORRO#2709) * feat(module:upload): Compatible with non-image format file preview - support download html attribute via linkProps * chore: support hide preview button when is non-image url
…ORRO#2709) * feat(module:upload): Compatible with non-image format file preview - support download html attribute via linkProps * chore: support hide preview button when is non-image url
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information