Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:upload): support with non-image format file preview #2709

Merged
merged 5 commits into from
Jan 17, 2019
Merged

feat(module:upload): support with non-image format file preview #2709

merged 5 commits into from
Jan 17, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Dec 29, 2018

  • support download html attribute via linkProps

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Dec 29, 2018

Deploy preview for ng-zorro-master ready!

Built with commit ff9c326

https://deploy-preview-2709--ng-zorro-master.netlify.com

@cipchk cipchk changed the title feat(module:upload): support with non-image format file preview WIP(module:upload): support with non-image format file preview Dec 29, 2018
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #2709 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2709      +/-   ##
=========================================
+ Coverage   95.57%   95.6%   +0.03%     
=========================================
  Files         507     507              
  Lines       12086   12132      +46     
  Branches     1701    1713      +12     
=========================================
+ Hits        11551   11599      +48     
+ Misses        171     170       -1     
+ Partials      364     363       -1
Impacted Files Coverage Δ
components/upload/nz-upload-list.component.ts 100% <100%> (ø) ⬆️
components/upload/nz-upload.component.ts 99.31% <100%> (-0.03%) ⬇️
components/upload/nz-upload-btn.component.ts 99.39% <0%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6554cf5...ff9c326. Read the comment docs.

@cipchk cipchk changed the title WIP(module:upload): support with non-image format file preview feat(module:upload): support with non-image format file preview Dec 29, 2018
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 903c2bb into NG-ZORRO:master Jan 17, 2019
vthinkxie pushed a commit that referenced this pull request Jan 17, 2019
* feat(module:upload): Compatible with non-image format file preview

- support download html attribute via linkProps

* chore: support hide preview button when is non-image url
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ORRO#2709)

* feat(module:upload): Compatible with non-image format file preview

- support download html attribute via linkProps

* chore: support hide preview button when is non-image url
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ORRO#2709)

* feat(module:upload): Compatible with non-image format file preview

- support download html attribute via linkProps

* chore: support hide preview button when is non-image url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants