feat(module:page-header): add page-header component #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsuanxyz
changed the title
|
Deploy preview for ng-zorro-master ready! Built with commit 79fdda7 |
Codecov Report
@@ Coverage Diff @@
## master #2732 +/- ##
==========================================
+ Coverage 97.34% 97.34% +<.01%
==========================================
Files 552 559 +7
Lines 11587 11635 +48
Branches 827 827
==========================================
+ Hits 11279 11326 +47
- Misses 195 196 +1
Partials 113 113
Continue to review full report at Codecov.
|
hsuanxyz
force-pushed
the
new/page-header
branch
from
0e20950 to
a4fa706
Compare
wzhudev
reviewed
Jan 14, 2019
wzhudev
reviewed
Jan 14, 2019
| ### nz-page-header | ||
| | 参数 | 说明 | 类型 | 默认值 | | ||
| | --- | --- | --- | --- | | ||
| | nzTitle | title 文字 | `string｜TemplateRef<void>` | - | |
There was a problem hiding this comment.
类似于 ReactNode ，TemplateRef 应该不需要做特殊说明
|
@hsuanxyz This is not blocked anymore since ant design had released this component. Please check: https://ant.design/components/page-header-cn/. |
|
I would like to see it in the new release :D |
hsuanxyz
force-pushed
the
new/page-header
branch
from
a4fa706 to
b9bfa01
Compare
hsuanxyz
changed the title
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:page-header): add page-header component * test(module:page-header): add test * style(module:page-header): fix tslint close NG-ZORRO#2710 * docs(module:page-header): update docs * chore: sync class name * test(module:page-header): fix test
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:page-header): add page-header component * test(module:page-header): add test * style(module:page-header): fix tslint close NG-ZORRO#2710 * docs(module:page-header): update docs * chore: sync class name * test(module:page-header): fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2710
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Ref ant-design/ant-design#13637