Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:comment): add comment component #2767

Merged
merged 5 commits into from
Feb 25, 2019

Conversation

hsuanxyz
Copy link
Member

close #2731

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2731

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz changed the title feat(module:comment): add comment component WIP(module:comment): add comment component Jan 11, 2019
@netlify
Copy link

netlify bot commented Jan 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit e2e4f99

https://deploy-preview-2767--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #2767 into master will increase coverage by 0.01%.
The diff coverage is 98.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
+ Coverage   97.37%   97.39%   +0.01%     
==========================================
  Files         530      537       +7     
  Lines       11093    11168      +75     
  Branches      804      805       +1     
==========================================
+ Hits        10802    10877      +75     
+ Misses        184      183       -1     
- Partials      107      108       +1
Impacted Files Coverage Δ
components/comment/demo/basic.ts 100% <100%> (ø)
components/comment/demo/nested.ts 100% <100%> (ø)
components/comment/nz-comment.module.ts 100% <100%> (ø)
components/comment/nz-comment.component.ts 100% <100%> (ø)
components/comment/demo/list.ts 100% <100%> (ø)
components/comment/demo/editor.ts 100% <100%> (ø)
components/comment/nz-comment-cells.ts 95.65% <95.65%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf9299...e2e4f99. Read the comment docs.

@hsuanxyz hsuanxyz changed the title WIP(module:comment): add comment component feat(module:comment): add comment component Jan 14, 2019
@hsuanxyz hsuanxyz requested review from wzhudev and vthinkxie and removed request for wzhudev January 14, 2019 09:48
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz force-pushed the new/comment branch 2 times, most recently from f5d113a to c5a5113 Compare January 17, 2019 03:39
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 1d68e44 into NG-ZORRO:master Feb 25, 2019
@hsuanxyz hsuanxyz deleted the new/comment branch April 22, 2019 02:41
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:comment): add comment component

close NG-ZORRO#2731

* test(module:comment): add test

* test(module:comment): fix test

* test(module:empty): refactor test

* test(module:empty): fix test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:comment): add comment component

close NG-ZORRO#2731

* test(module:comment): add test

* test(module:comment): fix test

* test(module:empty): refactor test

* test(module:empty): fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new component: comment
3 participants