-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:comment): add comment component #2767
Conversation
Deploy preview for ng-zorro-master ready! Built with commit e2e4f99 |
Codecov Report
@@ Coverage Diff @@
## master #2767 +/- ##
==========================================
+ Coverage 97.37% 97.39% +0.01%
==========================================
Files 530 537 +7
Lines 11093 11168 +75
Branches 804 805 +1
==========================================
+ Hits 10802 10877 +75
+ Misses 184 183 -1
- Partials 107 108 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f5d113a
to
c5a5113
Compare
c5a5113
to
18c477c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(module:comment): add comment component close NG-ZORRO#2731 * test(module:comment): add test * test(module:comment): fix test * test(module:empty): refactor test * test(module:empty): fix test
* feat(module:comment): add comment component close NG-ZORRO#2731 * test(module:comment): add test * test(module:comment): fix test * test(module:empty): refactor test * test(module:empty): fix test
close #2731
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2731
What is the new behavior?
Does this PR introduce a breaking change?
Other information