feat(module:input): fix *fix icon new api capability #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 9fce4e2 |
Codecov Report
@@ Coverage Diff @@
## master #2841 +/- ##
==========================================
+ Coverage 95.48% 95.48% +<.01%
==========================================
Files 523 523
Lines 12239 12253 +14
Branches 1668 1673 +5
==========================================
+ Hits 11686 11700 +14
Misses 198 198
Partials 355 355
Continue to review full report at Codecov.
|
wzhudev
force-pushed
the
fix-test-icon
branch
from
807b72e to
9fce4e2
Compare
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:input): fix *fix icon new api capability * fix(module:icon): fix setting class to undefined * fix: remove test flag * fix(module:icon): remove redundant error handle
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:input): fix *fix icon new api capability * fix(module:icon): fix setting class to undefined * fix: remove test flag * fix(module:icon): remove redundant error handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Fix some test failures because
NzIconTestModuleis not imported.