Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): support set nzOkDisabled and nzCancelDisabled #2856

Merged
merged 7 commits into from
Feb 1, 2019

Conversation

kekehaoz
Copy link
Contributor

@kekehaoz kekehaoz commented Jan 29, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Modal doesn't support set nzOkDisabled and nzCancelDisabled

Issue Number: #1838

What is the new behavior?

Modal support set nzOkDisabled and nzCancelDisabled

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 29, 2019

Deploy preview for ng-zorro-master ready!

Built with commit b17add6

https://deploy-preview-2856--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #2856 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2856      +/-   ##
==========================================
- Coverage    95.5%   95.48%   -0.03%     
==========================================
  Files         523      523              
  Lines       12236    12241       +5     
  Branches     1668     1668              
==========================================
+ Hits        11686    11688       +2     
- Misses        197      198       +1     
- Partials      353      355       +2
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 95.88% <100%> (+0.03%) ⬆️
components/radio/nz-radio-group.component.ts 90% <0%> (-3.34%) ⬇️
components/select/nz-option-container.component.ts 95.12% <0%> (-2.44%) ⬇️
components/anchor/nz-anchor.component.ts 100% <0%> (ø) ⬆️
components/radio/nz-radio.component.ts 98.3% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f21d0...e55bc65. Read the comment docs.

@netlify
Copy link

netlify bot commented Jan 29, 2019

Deploy preview for ng-zorro-master ready!

Built with commit e55bc65

https://deploy-preview-2856--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz changed the title feat: modal support set nzOkDisabled and nzCancelDisabled(#1838) feat: modal support set nzOkDisabled and nzCancelDisabled Jan 30, 2019
@hsuanxyz hsuanxyz changed the title feat: modal support set nzOkDisabled and nzCancelDisabled feat(module:modal): support set nzOkDisabled and nzCancelDisabled Jan 30, 2019
@wzhudev
Copy link
Member

wzhudev commented Jan 30, 2019

Should have a test.

@kekehaoz
Copy link
Contributor Author

unit test already added

components/modal/doc/index.zh-CN.md Outdated Show resolved Hide resolved
@hsuanxyz hsuanxyz merged commit fa6a8e9 into NG-ZORRO:master Feb 1, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants