Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix component group name translation #2998

Closed
wants to merge 1 commit into from

Conversation

ppjjzz
Copy link
Contributor

@ppjjzz ppjjzz commented Feb 28, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 52bb9dc

https://deploy-preview-2998--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #2998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2998   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files         550      550           
  Lines       11452    11452           
  Branches      813      813           
=======================================
  Hits        11149    11149           
  Misses        190      190           
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db070d...52bb9dc. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只需要将 components/**/doc/index.zh-CN.md 中的 type 自动改成中文就可以,就像这样:

components/affix/doc/index.zh-CN.md

---
category: Components
subtitle: 固钉
- type: Navigation
+ type: 导航
title: Affix
---

@ppjjzz
Copy link
Contributor Author

ppjjzz commented Mar 1, 2019

只需要将 components/**/doc/index.zh-CN.md 中的 type 自动改成中文就可以,就像这样:

components/affix/doc/index.zh-CN.md

---
category: Components
subtitle: 固钉
- type: Navigation
+ type: 导航
title: Affix
---

我试过这样改会导致切到英文时还是会显示中文名

@@ -24,6 +24,16 @@ module.exports = function generateRoutes(showCaseTargetPath, componentsMap, docs
intro.sort((pre, next) => pre.order - next.order);
fs.writeFileSync(path.join(showCaseTargetPath, `intros.json`), JSON.stringify(intro, null, 2));
const reverseMap = {};
const typeMap = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppjjzz 应该从markdown文件中读取数据,不应该写死在打包脚本中

@vthinkxie vthinkxie mentioned this pull request Apr 16, 2019
3 tasks
vthinkxie added a commit that referenced this pull request Apr 16, 2019
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants