-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:i18n): fix catalan translations #3080
Conversation
Deploy preview for ng-zorro-master ready! Built with commit b78d61d |
Codecov Report
@@ Coverage Diff @@
## master #3080 +/- ##
==========================================
+ Coverage 97.34% 97.37% +0.03%
==========================================
Files 552 559 +7
Lines 11587 11627 +40
Branches 827 835 +8
==========================================
+ Hits 11279 11322 +43
+ Misses 195 193 -2
+ Partials 113 112 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing!
@@ -2,7 +2,7 @@ export default { | |||
// Options.jsx | |||
items_per_page: '/ pàgina', | |||
jump_to: 'Anar a', | |||
jump_to_confirm: 'Confirma', | |||
jump_to_confirm: 'confirmar', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Why this pull request is not merged? I really need it. |
|
@gpalomar Got a minute to rebase and make the letter capitalized? ;) |
I wrote it in lowercase because almost all languages has it in lowercase. I'm going to do an update replacing "confirma" with "Confirma" but be aware that only the following languages has that string capitalized: et_EE, fi_FI, it_IT. |
* fix(module:i18n): fix catalan translations * fix(module:i18n): fix for catalan "jump_to_confirm" string close NG-ZORRO#2569
* fix(module:i18n): fix catalan translations * fix(module:i18n): fix for catalan "jump_to_confirm" string close NG-ZORRO#2569
* fix(module:i18n): fix catalan translations * fix(module:i18n): fix for catalan "jump_to_confirm" string close NG-ZORRO#2569
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This pull request fixes the missing catalan translations.
Issue Number: #2569
What is the new behavior?
Does this PR introduce a breaking change?
Other information