Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:i18n): fix catalan translations #3080

Merged
merged 2 commits into from
Apr 15, 2019
Merged

fix(module:i18n): fix catalan translations #3080

merged 2 commits into from
Apr 15, 2019

Conversation

gpalomar
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

This pull request fixes the missing catalan translations.

Issue Number: #2569

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@netlify
Copy link

netlify bot commented Mar 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit b78d61d

https://deploy-preview-3080--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #3080 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
+ Coverage   97.34%   97.37%   +0.03%     
==========================================
  Files         552      559       +7     
  Lines       11587    11627      +40     
  Branches      827      835       +8     
==========================================
+ Hits        11279    11322      +43     
+ Misses        195      193       -2     
+ Partials      113      112       -1
Impacted Files Coverage Δ
components/i18n/languages/pagination/ca_ES.ts 100% <ø> (ø) ⬆️
components/i18n/languages/ca_ES.ts 100% <ø> (ø) ⬆️
components/core/scroll/nz-scroll.service.ts 79.16% <0%> (-2.09%) ⬇️
...omponents/date-picker/lib/candy-date/candy-date.ts 100% <0%> (ø) ⬆️
components/core/overlay/nz-connected-overlay.ts 100% <0%> (ø) ⬆️
components/core/animation/zoom.ts 100% <0%> (ø) ⬆️
components/core/util/check.ts 91.66% <0%> (ø) ⬆️
...te-picker/lib/calendar/calendar-input.component.ts 96.77% <0%> (ø) ⬆️
components/core/testing/event-objects.ts 92.59% <0%> (ø) ⬆️
...te-picker/lib/popups/date-range-popup.component.ts 96.7% <0%> (ø) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e319...b78d61d. Read the comment docs.

wzhudev
wzhudev previously approved these changes Mar 13, 2019
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@@ -2,7 +2,7 @@ export default {
// Options.jsx
items_per_page: '/ pàgina',
jump_to: 'Anar a',
jump_to_confirm: 'Confirma',
jump_to_confirm: 'confirmar',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be capitalized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@gpalomar
Copy link
Contributor Author

Why this pull request is not merged? I really need it.

@vthinkxie
Copy link
Member

Why this pull request is not merged? I really need it.

confirmar should be Confirmar

@wzhudev
Copy link
Member

wzhudev commented Apr 3, 2019

@gpalomar Got a minute to rebase and make the letter capitalized? ;)

@gpalomar
Copy link
Contributor Author

I wrote it in lowercase because almost all languages has it in lowercase. I'm going to do an update replacing "confirma" with "Confirma" but be aware that only the following languages has that string capitalized: et_EE, fi_FI, it_IT.

@hsuanxyz hsuanxyz merged commit 81f917a into NG-ZORRO:master Apr 15, 2019
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
* fix(module:i18n): fix catalan translations

* fix(module:i18n): fix for catalan "jump_to_confirm" string

close NG-ZORRO#2569
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:i18n): fix catalan translations

* fix(module:i18n): fix for catalan "jump_to_confirm" string

close NG-ZORRO#2569
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:i18n): fix catalan translations

* fix(module:i18n): fix for catalan "jump_to_confirm" string

close NG-ZORRO#2569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants