Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:upload): fix missing remove event when type is drag #3114

Merged
merged 11 commits into from
Mar 27, 2019
Merged

fix(module:upload): fix missing remove event when type is drag #3114

merged 11 commits into from
Mar 27, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Mar 17, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3034 #3139 #3171

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

cipchk and others added 10 commits December 8, 2018 16:41
@cipchk
Merge pull request #1 from NG-ZORRO/master
f4e27e3 
merge
@cipchk
Merge pull request #2 from NG-ZORRO/master
84b3c18 
upgrade
@cipchk
Merge pull request #3 from NG-ZORRO/master
993ebea 
upgrade
@cipchk
Merge pull request #4 from NG-ZORRO/master
9f6cc07 
merge master
@cipchk
Merge pull request #5 from NG-ZORRO/master
e762917 
merge master
@cipchk
Merge pull request #7 from NG-ZORRO/master
cb029b6 
chore: merge master
@cipchk @vthinkxie
@hsuanxyz @wilsoncook @ng-zorro-bot @danranVm @YuhuiM
Merge pull request #10 from NG-ZORRO/master
c9ecdec 
chore: merge master

Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by:  <krokofant@users.noreply.github.com>
Co-authored-by: Wilson Zeng <jackzcs@gmail.com>
Co-authored-by: null <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: Ekko <danranvm@gmail.com>
Co-authored-by: null <33438314+myh6666@users.noreply.github.com>
@cipchk @vthinkxie
@wilsoncook @hsuanxyz @tonny008 @zhytang @dodobelieve
Merge pull request #11 from NG-ZORRO/master
06f4581 
chore: merge master

Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by: Wilson Zeng <jackzcs@gmail.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: GQ <tonny008@163.com>
Co-authored-by:  <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: null <231785421@qq.com>
Co-authored-by: simplejason <tangjie@yinspect.com>
Co-authored-by: null <37918438+dodobelieve@users.noreply.github.com>
@cipchk @vthinkxie @myfreax
Merge pull request #12 from NG-ZORRO/master
54953a0 
chore: merge master

Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by:  <coderpoet@outlook.com>
Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by: Freax <huangyanxiong2013@gmail.com>
@cipchk
fix(module:upload): fix missing remove event when type is drag
acf26e2
@netlify
Copy link

netlify bot commented Mar 17, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit 8418dc0

https://deploy-preview-3114--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 17, 2019 •
edited
Loading

Codecov Report

Merging #3114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3114   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         552      552           
  Lines       11587    11587           
  Branches      827      827           
=======================================
  Hits        11279    11279           
  Misses        195      195           
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e319...8418dc0. Read the comment docs.

@cipchk cipchk mentioned this pull request Mar 25, 2019
Closed
@cipchk cipchk requested a review from vthinkxie March 27, 2019 04:31
vthinkxie
vthinkxie approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 2b1fdd9 into NG-ZORRO:master Mar 27, 2019
@weekly-digest weekly-digest bot mentioned this pull request Apr 1, 2019
Closed
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@cipchk @Ricbet
fix(module:upload): fix missing remove event when type is drag (NG-ZO…
6c4072c 
…RRO#3114)

close NG-ZORRO#3034 close NG-ZORRO#3139 close NG-ZORRO#3171
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@cipchk @vthinkxie
fix(module:upload): fix missing remove event when type is drag (NG-ZO…
1822a44 
…RRO#3114)

close NG-ZORRO#3034 close NG-ZORRO#3139 close NG-ZORRO#3171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cipchk @vthinkxie @hsuanxyz