Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): Compatible with the locale zh-tw (#3165) #3170

Closed
wants to merge 3 commits into from

Conversation

renxia
Copy link
Contributor

@renxia renxia commented Mar 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit dfaee6e

https://deploy-preview-3170--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #3170 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3170      +/-   ##
==========================================
+ Coverage   97.34%   97.34%   +<.01%     
==========================================
  Files         552      552              
  Lines       11587    11591       +4     
  Branches      827      828       +1     
==========================================
+ Hits        11279    11283       +4     
  Misses        195      195              
  Partials      113      113
Impacted Files Coverage Δ
components/i18n/nz-i18n.service.ts 85.71% <100%> (+1.09%) ⬆️
components/i18n/date-helper.service.ts 88.88% <100%> (ø) ⬆️
components/i18n/nz-i18n.module.ts 100% <100%> (ø) ⬆️
components/i18n/nz-i18n.token.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e319...dfaee6e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant