Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:collapse): support nzExtra #3177

Merged
merged 3 commits into from
Mar 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions components/collapse/demo/extra.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
order: 5
title:
zh-CN: 额外节点
en-US: Extra Node
---

## zh-CN

你可以通过 `nzExtra` 来指定面板右上角的额外内容。

## en-US

You can use `nzExtra` to put extra elements in the top right corner.
44 changes: 44 additions & 0 deletions components/collapse/demo/extra.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { Component } from '@angular/core';

@Component({
selector: 'nz-demo-collapse-extra',
template: `
<nz-collapse>
<nz-collapse-panel
*ngFor="let panel of panels"
[nzHeader]="panel.name"
[nzActive]="panel.active"
[nzExtra]="extraTpl"
[nzDisabled]="panel.disabled"
>
<p style="margin:0;">
A dog is a type of domesticated animal. Known for its loyalty and faithfulness, it can be found as a welcome
guest in many households across the world.
</p>
</nz-collapse-panel>
</nz-collapse>
<ng-template #extraTpl>
<i nz-icon nzType="setting"></i>
</ng-template>
`,
styles: []
})
export class NzDemoCollapseExtraComponent {
panels = [
{
active: true,
name: 'This is panel header 1',
disabled: false
},
{
active: false,
disabled: false,
name: 'This is panel header 2'
},
{
active: false,
disabled: true,
name: 'This is panel header 3'
}
];
}
3 changes: 2 additions & 1 deletion components/collapse/doc/index.en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ A content area which can be collapsed and expanded.
| -------- | ----------- | ---- | ------- |
| `[nzDisabled]` | If `true`, panel cannot be opened or closed | `boolean` | `false` |
| `[nzHeader]` | Title of the panel | `string|TemplateRef<void>` | - |
| `[nzExpandedIcon]` | Customize an icon for toggle | `string|TemplateRef<void>` | - |
| `[nzExtra]` | Extra element in the corner | `string|TemplateRef<void>` | - |
| `[nzShowArrow]` | Display arrow or not | `boolean` | `true` |
| `[nzActive]` | Active status of panel, double binding | `boolean` | - |
| `(nzActiveChange)` | Callback function of the active status | `EventEmitter<boolean>` | - |
| `[nzExpandedIcon]` | Customize an icon for toggle | `string|TemplateRef<void>` | - |
3 changes: 2 additions & 1 deletion components/collapse/doc/index.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ cols: 1
| --- | --- | --- | --- |
| `[nzDisabled]` | 禁用后的面板展开与否将无法通过用户交互改变 | `boolean` | `false` |
| `[nzHeader]` | 面板头内容 | `string|TemplateRef<void>` | - |
| `[nzExpandedIcon]` | 自定义切换图标 | `string|TemplateRef<void>` | - |
| `[nzExtra]` | 自定义渲染每个面板右上角的内容 | `string|TemplateRef<void>` | - |
| `[nzShowArrow]` | 是否展示箭头 | `boolean` | `true` |
| `[nzActive]` | 面板是否展开,可双向绑定 | `boolean` | - |
| `(nzActiveChange)` | 面板展开回调 | `EventEmitter<boolean>` | - |
| `[nzExpandedIcon]` | 自定义切换图标 | `string|TemplateRef<void>` | - |
3 changes: 3 additions & 0 deletions components/collapse/nz-collapse-panel.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
</ng-container>
</ng-container>
<ng-container *nzStringTemplateOutlet="nzHeader">{{ nzHeader }}</ng-container>
<div class="ant-collapse-extra" *ngIf="nzExtra">
<ng-container *nzStringTemplateOutlet="nzExtra">{{ nzExtra }}</ng-container>
</div>
</div>
<div class="ant-collapse-content"
[class.ant-collapse-content-active]="nzActive"
Expand Down
1 change: 1 addition & 0 deletions components/collapse/nz-collapse-panel.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export class NzCollapsePanelComponent implements OnInit, OnDestroy {
@Input() @InputBoolean() @HostBinding('class.ant-collapse-item-active') nzActive = false;
@Input() @InputBoolean() @HostBinding('class.ant-collapse-item-disabled') nzDisabled = false;
@Input() @InputBoolean() nzShowArrow = true;
@Input() nzExtra: string | TemplateRef<void>;
@Input() nzHeader: string | TemplateRef<void>;
@Input() nzExpandedIcon: string | TemplateRef<void>;
@Output() readonly nzActiveChange = new EventEmitter<boolean>();
Expand Down
13 changes: 12 additions & 1 deletion components/collapse/nz-collapse.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,16 @@ describe('collapse', () => {
fixture.detectChanges();
expect(panels[0].nativeElement.querySelector('.ant-collapse-header').innerText).toBe('string');
});
it('should extra work', () => {
fixture.detectChanges();
expect(panels[0].nativeElement.querySelector('.ant-collapse-extra')).toBeFalsy();

testComponent.showExtra = 'Extra';
fixture.detectChanges();
const extraEl = panels[0].nativeElement.querySelector('.ant-collapse-extra');
expect(extraEl!).not.toBeFalsy();
expect(extraEl!.innerText).toBe('Extra');
});
});
describe('collapse template', () => {
let fixture: ComponentFixture<NzTestCollapseTemplateComponent>;
Expand Down Expand Up @@ -171,6 +181,7 @@ describe('collapse', () => {
(nzActiveChange)="active01Change($event)"
[nzHeader]="header"
[nzShowArrow]="showArrow"
[nzExtra]="showExtra"
>
<p>Panel01</p>
</nz-collapse-panel>
Expand All @@ -188,7 +199,7 @@ export class NzTestCollapseBasicComponent {
active01 = false;
active02 = false;
showArrow = true;
// showExtra = '';
showExtra = '';
header = 'string';
active01Change = jasmine.createSpy('active01 callback');
active02Change = jasmine.createSpy('active02 callback');
Expand Down
4 changes: 4 additions & 0 deletions components/collapse/style/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
}
}

.@{collapse-prefix-cls}-extra {
float: right;
}

&:focus {
outline: none;
}
Expand Down
2 changes: 1 addition & 1 deletion components/style/themes/default.less
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@

// Collapse
// ---
@collapse-header-padding: 12px 0 12px 40px;
@collapse-header-padding: 12px 16px 12px 40px;
@collapse-header-bg: @background-color-light;
@collapse-content-padding: @padding-md;
@collapse-content-bg: @component-background;
Expand Down
2 changes: 1 addition & 1 deletion scripts/site/_site/doc/theme.less
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@

// Collapse
// ---
@collapse-header-padding: 12px 0 12px 40px;
@collapse-header-padding: 12px 16px 12px 40px;
@collapse-header-bg: @background-color-light;
@collapse-content-padding: @padding-md;
@collapse-content-bg: @component-background;
Expand Down