Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:breadcrumb): fix input boolean and router event not caught error #3185

Merged
merged 5 commits into from
May 17, 2019
Merged

fix(module:breadcrumb): fix input boolean and router event not caught error #3185

merged 5 commits into from
May 17, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 28, 2019 •
edited
Loading

close #3186

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

屏幕录制 2019-04-24 19 46 47

You can find the demo here.

@wzhudev wzhudev requested a review from simplejason March 28, 2019 12:12
@netlify
Copy link

netlify bot commented Mar 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6640a26

https://deploy-preview-3185--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented Mar 28, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit ed8e713

https://deploy-preview-3185--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 28, 2019 •
edited
Loading

Codecov Report

Merging #3185 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
+ Coverage    95.5%   95.59%   +0.09%     
==========================================
  Files         609      609              
  Lines       13217    13241      +24     
  Branches     1805     1809       +4     
==========================================
+ Hits        12623    12658      +35     
+ Misses        212      197      -15     
- Partials      382      386       +4
Impacted Files Coverage Δ
components/breadcrumb/nz-breadcrumb.component.ts 92.15% <100%> (+35.63%) ⬆️
components/icon/testing/nz-icon-test.module.ts 100% <100%> (ø) ⬆️
...nts/core/no-animation/nz-no-animation.directive.ts 81.81% <0%> (-9.1%) ⬇️
components/modal/nz-modal.component.ts 95.29% <0%> (-1.02%) ⬇️
components/drawer/nz-drawer.service.ts 100% <0%> (ø) ⬆️
components/modal/nz-modal.service.ts 91.17% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663f6c1...ed8e713. Read the comment docs.

@weekly-digest weekly-digest bot mentioned this pull request Apr 1, 2019
Closed
@wzhudev wzhudev closed this Apr 12, 2019
@wzhudev wzhudev deleted the breadcrumb branch April 12, 2019 04:01
@wzhudev wzhudev restored the breadcrumb branch April 15, 2019 12:15
@wzhudev wzhudev reopened this Apr 15, 2019
@wzhudev wzhudev removed the request for review from simplejason April 16, 2019 10:56
@wzhudev wzhudev changed the title fix(module:breadcrumb): fix input boolean and lazy module slash fix(module:breadcrumb): fix input boolean and router event not catched error Apr 26, 2019
Wendell added 2 commits April 29, 2019 15:06
fix(module:breadcrumb): fix input boolean and lazy module slash
23e644b 
close NG-ZORRO#3186

docs: add link

fix: fix breadcrumb not updated

fix: typo
test: add test
e626bca
@wenqi73 wenqi73 requested a review from hsuanxyz May 17, 2019 12:46
@wenqi73 wenqi73 changed the title fix(module:breadcrumb): fix input boolean and router event not catched error fix(module:breadcrumb): fix input boolean and router event not caught error May 17, 2019
@wenqi73 wenqi73 merged commit fd43ec5 into NG-ZORRO:master May 17, 2019
@wzhudev wzhudev deleted the breadcrumb branch June 24, 2019 06:36
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
fix(module:breadcrumb): fix input boolean and router event not caught…
197e25a 
… error (NG-ZORRO#3185)

* fix(module:breadcrumb): fix input boolean and lazy module slash

docs: add link

fix: fix breadcrumb not updated

fix: typo

* test: add test

* chore: cleanup code

* chore: rollback

* chore: remove vscode

close NG-ZORRO#3186
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@wenqi73
fix(module:breadcrumb): fix input boolean and router event not caught…
a7e1c47 
… error (NG-ZORRO#3185)

* fix(module:breadcrumb): fix input boolean and lazy module slash

docs: add link

fix: fix breadcrumb not updated

fix: typo

* test: add test

* chore: cleanup code

* chore: rollback

* chore: remove vscode

close NG-ZORRO#3186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenqi73 wenqi73 wenqi73 approved these changes

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

breadcrumb doesn't work @v7.2.0 when nzAutoGenerate is true
3 participants
@wzhudev @wenqi73 @hsuanxyz