-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(menu): animate expand/collapse menu #330
feature(menu): animate expand/collapse menu #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your pr very much, height should not be animated when [nzMode]="'vertical'", the bugs will happened with nested submenu.
@vthinkxie 请问你说的 bug 具体是指什么?在我的测试中是发现第2级菜单无法正常显示,目前已经确定是 |
It would be better not animation height when [nzMode]="'vertical'" |
Hi, @maroon1 ,please keep your commit history clean, you can use rebase and sqush to remove unused commit history. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
子菜单展开/收起时,高度突变
Issue Number: N/A
What is the new behavior?
子菜单展开/收起时,高度变化有动画效果
Does this PR introduce a breaking change?
Other information