Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(module:page-header): fix typo in event-binding notation #3370

Closed
wants to merge 1 commit into from
Closed

docs(module:page-header): fix typo in event-binding notation #3370

wants to merge 1 commit into from

Conversation

avin-kavish
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

Changed [] to () for Event Emitter.

@netlify
Copy link

netlify bot commented Apr 25, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 3418821

https://deploy-preview-3370--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #3370 into master will decrease coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
- Coverage   96.66%   95.48%   -1.18%     
==========================================
  Files         609      609              
  Lines       13187    13187              
  Branches     1803     1803              
==========================================
- Hits        12747    12592     -155     
- Misses        199      215      +16     
- Partials      241      380     +139
Impacted Files Coverage Δ
components/core/util/getMentions.ts 50% <0%> (-16.67%) ⬇️
components/core/scroll/nz-scroll.service.ts 66.03% <0%> (-13.21%) ⬇️
components/core/polyfill/request-animation.ts 20% <0%> (-12%) ⬇️
components/slider/nz-slider-step.component.ts 88.88% <0%> (-11.12%) ⬇️
components/i18n/nz-i18n.service.ts 80.95% <0%> (-9.53%) ⬇️
components/core/util/textarea-caret-position.ts 42.1% <0%> (-8.78%) ⬇️
components/breadcrumb/nz-breadcrumb.component.ts 56.52% <0%> (-6.53%) ⬇️
components/slider/nz-slider-marks.component.ts 90.47% <0%> (-4.77%) ⬇️
components/select/nz-option-container.component.ts 95.34% <0%> (-4.66%) ⬇️
components/core/util/throttleByAnimationFrame.ts 90.9% <0%> (-4.55%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f353c...3418821. Read the comment docs.

@hsuanxyz
Copy link
Member

Thanks for contributing, please modify the commit message according to this CONTRIBUTING #Commit Message Guidelines

suggestion: docs(module:page-header): fix typo in event-binding notation

@hsuanxyz hsuanxyz changed the title DOCS Page Header - Fixed typo in Event Binding notation docs(module:page-header): fix typo in event-binding notation Apr 28, 2019
@avin-kavish
Copy link
Author

avin-kavish commented May 16, 2019

@hsuanxyz Done :)

@wzhudev
Copy link
Member

wzhudev commented Jul 19, 2019

@avin-kavish Thanks for your PR. These typos had been fixed in our recent commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants