Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): support nzOnCancel for service mode #3376

Merged
merged 3 commits into from
May 17, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3372

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #3376 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3376      +/-   ##
==========================================
- Coverage   97.44%   97.43%   -0.01%     
==========================================
  Files         609      609              
  Lines       11947    11950       +3     
  Branches      871      871              
==========================================
+ Hits        11642    11644       +2     
- Misses        196      197       +1     
  Partials      109      109
Impacted Files Coverage Δ
components/drawer/nz-drawer.component.ts 99.32% <ø> (ø) ⬆️
components/drawer/nz-drawer.service.ts 100% <100%> (ø) ⬆️
...nts/core/no-animation/nz-no-animation.directive.ts 90.47% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbce3fa...36af696. Read the comment docs.

@netlify
Copy link

netlify bot commented Apr 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 36af696

https://deploy-preview-3376--ng-zorro-master.netlify.com

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得接口名不改为好

components/drawer/nz-drawer-options.ts Show resolved Hide resolved
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 3742eda into NG-ZORRO:master May 17, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…3376)

close NG-ZORRO#3372

* feat(module:drawer): support `nzOnCancel` for service mode

* docs(module:drawer): fix docs

* docs(module:drawer): fix docs
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…3376)

close NG-ZORRO#3372

* feat(module:drawer): support `nzOnCancel` for service mode

* docs(module:drawer): fix docs

* docs(module:drawer): fix docs
@hsuanxyz hsuanxyz deleted the feat/drawer-on-close branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants