-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:drawer): support nzOnCancel
for service mode
#3376
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3376 +/- ##
==========================================
- Coverage 97.44% 97.43% -0.01%
==========================================
Files 609 609
Lines 11947 11950 +3
Branches 871 871
==========================================
+ Hits 11642 11644 +2
- Misses 196 197 +1
Partials 109 109
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 36af696 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得接口名不改为好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…3376) close NG-ZORRO#3372 * feat(module:drawer): support `nzOnCancel` for service mode * docs(module:drawer): fix docs * docs(module:drawer): fix docs
…3376) close NG-ZORRO#3372 * feat(module:drawer): support `nzOnCancel` for service mode * docs(module:drawer): fix docs * docs(module:drawer): fix docs
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3372
What is the new behavior?
Does this PR introduce a breaking change?
Other information