Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tree,tree-select): expand [selectable:false] or [disableCheckbox:true] node when click #3399

Closed
wants to merge 1 commit into from

Conversation

huangxiuqi
Copy link

Close #3157

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3157

What is the new behavior?

Expand this node if the clicked node has a [disableCheckbox:true] or [selectable:false] attribute

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@huangxiuqi huangxiuqi closed this May 4, 2019
@netlify
Copy link

netlify bot commented May 4, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 78f5727

https://deploy-preview-3399--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #3399 into master will decrease coverage by 1.98%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3399      +/-   ##
==========================================
- Coverage   97.44%   95.45%   -1.99%     
==========================================
  Files         609      609              
  Lines       11947    13193    +1246     
  Branches      871     1804     +933     
==========================================
+ Hits        11642    12594     +952     
- Misses        196      218      +22     
- Partials      109      381     +272
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 99.04% <100%> (-0.43%) ⬇️
components/tree/nz-tree-node.component.ts 93.1% <20%> (-4.03%) ⬇️
components/core/util/scroll-into-view-if-needed.ts 50% <0%> (-16.67%) ⬇️
components/core/logger/logger.service.ts 56.52% <0%> (-15.71%) ⬇️
components/core/addon/string_template_outlet.ts 88% <0%> (-12%) ⬇️
components/core/util/getMentions.ts 50% <0%> (-10%) ⬇️
components/statistic/nz-countdown.component.ts 84.21% <0%> (-9.54%) ⬇️
components/core/wave/nz-wave-renderer.ts 87.87% <0%> (-8.55%) ⬇️
...date-picker/lib/calendar/today-button.component.ts 91.66% <0%> (-8.34%) ⬇️
components/message/nz-message.component.ts 89.79% <0%> (-7.83%) ⬇️
... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f353c...78f5727. Read the comment docs.

@huangxiuqi huangxiuqi deleted the my-fix-branch branch May 4, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree-select 子节点使用selectable:false禁止选中后,希望能点击此节点时能展开此节点
1 participant