fix(module:modal): should not close when mousedown in the body #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 3d0b864 |
Codecov Report
@@ Coverage Diff @@
## master #3400 +/- ##
==========================================
+ Coverage 95.47% 95.47% +<.01%
==========================================
Files 609 609
Lines 13234 13243 +9
Branches 1810 1811 +1
==========================================
+ Hits 12635 12644 +9
Misses 214 214
Partials 385 385
Continue to review full report at Codecov.
|
hsuanxyz
force-pushed
the
fix/modal-mouse-down
branch
from
e851ba6 to
3d0b864
Compare
wenqi73
approved these changes
May 17, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
…RRO#3400) * fix(module:modal): should not close when mousedown in the body * chore(module:modal): use variable to save classname string close NG-ZORRO#3394
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…RRO#3400) * fix(module:modal): should not close when mousedown in the body * chore(module:modal): use variable to save classname string close NG-ZORRO#3394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3394
What is the new behavior?
Does this PR introduce a breaking change?
Other information