refactor(module:list): refactor list component #3422

cipchk · 2019-05-08T03:05:35Z

limited by chore: sync ant-design v3.17.0 #3406, muse be wait for the chore: sync ant-design v3.17.0 #3406 merged
fix misplacement in vertical layout 竖排图文列表图片显示位置错乱 #3404
add nzNoFlex property in nz-list-item
support attribute name of selector, what using ul element in dom structure

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

merge

upgrade

merge master

chore: merge master

chore: merge master Co-authored-by: Wendell <wendzhue@gmail.com> Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com> Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: <krokofant@users.noreply.github.com> Co-authored-by: Wilson Zeng <jackzcs@gmail.com> Co-authored-by: null <33472860+ng-zorro-bot@users.noreply.github.com> Co-authored-by: Ekko <danranvm@gmail.com> Co-authored-by: null <33438314+myh6666@users.noreply.github.com>

chore: merge master Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com> Co-authored-by: Wendell <wendzhue@gmail.com> Co-authored-by: Wilson Zeng <jackzcs@gmail.com> Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: GQ <tonny008@163.com> Co-authored-by: <33472860+ng-zorro-bot@users.noreply.github.com> Co-authored-by: null <231785421@qq.com> Co-authored-by: simplejason <tangjie@yinspect.com> Co-authored-by: null <37918438+dodobelieve@users.noreply.github.com>

chore: merge master Co-authored-by: Wendell <wendzhue@gmail.com> Co-authored-by: <coderpoet@outlook.com> Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com> Co-authored-by: Freax <huangyanxiong2013@gmail.com>

chore: merge master Co-authored-by: Wendell <wendzhue@gmail.com> Co-authored-by: Rasheed Rahman <11582800+radiumrasheed@users.noreply.github.com> Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: null <kayphay92@gmail.com> Co-authored-by: simplejason <tangjie@yinspect.com>

chore: merge master Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: Ethan Zhao <zdpluto@gmail.com> Co-authored-by: Wendell <wendzhue@gmail.com>

chore: merge master Co-authored-by: <kekehao1212@outlook.com> Co-authored-by: <33472860+ng-zorro-bot@users.noreply.github.com>

chore: merge master Co-authored-by: Ekko <danranvm@gmail.com> Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: simplejason <tangjie@yinspect.com> Co-authored-by: Guillem Palomar <guillem.palomar.agramunt@gmail.com> Co-authored-by: Nickbing Lao <giscafer@outlook.com> Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com> Co-authored-by: <pwjay.ok@163.com> Co-authored-by: Sunny Liu <lx1036@126.com> Co-authored-by: <kekehao1212@outlook.com> Co-authored-by: Wendell <wendzhue@gmail.com>

chore: merge master Co-authored-by: <33472860+ng-zorro-bot@users.noreply.github.com> Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com> Co-authored-by: Wendell <wendzhue@gmail.com> Co-authored-by: 雪狼 <asnowwolf@users.noreply.github.com> Co-authored-by: simplejason <tangjie@yinspect.com> Co-authored-by: <pwjay.ok@163.com> Co-authored-by: olive.wang <olive@olivewind.com> Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: <binglingshuang@163.com>

- limited by #3406, muse be wait for the #3406 merged - fix misplacement in vertical layout #3404 - add `nzNoFlex` property in nz-list-item - support attribute name of selector, what using ul element in dom structure

codecov · 2019-05-08T03:23:51Z

Codecov Report

Merging #3422 into master will increase coverage by 0.01%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master    #3422      +/-   ##
==========================================
+ Coverage   95.72%   95.73%   +0.01%     
==========================================
  Files         690      690              
  Lines       13708    13729      +21     
  Branches     1824     1827       +3     
==========================================
+ Hits        13122    13144      +22     
  Misses        198      198              
+ Partials      388      387       -1

Impacted Files	Coverage Δ
components/list/nz-list-item-meta.component.ts	`100% <ø> (ø)`	⬆️
components/list/nz-list.component.ts	`100% <100%> (ø)`	⬆️
components/list/nz-list-item.component.ts	`95.65% <93.75%> (-4.35%)`	⬇️
components/time-picker/time-holder.ts	`97.94% <0%> (+1.36%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42daeba...e038f25. Read the comment docs.

chore: merge master Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: JerryHong <s6323859@gmail.com> Co-authored-by: Wendell <wendzhue@gmail.com> Co-authored-by: null <binglingshuang@163.com> Co-authored-by: Wenqi <1264578441@qq.com> Co-authored-by: Joshua Harris <joshuadaleharris@gmail.com> Co-authored-by: Gleb Mikheev <mikheev@betaagency.ru> Co-authored-by: null <2535612040@qq.com> Co-authored-by: simplejason <simplejason.coder@gmail.com> Co-authored-by: ivan <ivanwonder@outlook.com> Co-authored-by: null <33472860+ng-zorro-bot@users.noreply.github.com> Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>

netlify · 2019-06-16T04:11:15Z

Deploy preview for ng-zorro-master ready!

Built with commit e038f25

https://deploy-preview-3422--ng-zorro-master.netlify.com

- limited by NG-ZORRO#3406, muse be wait for the NG-ZORRO#3406 merged - fix misplacement in vertical layout NG-ZORRO#3404 - add `nzNoFlex` property in nz-list-item - support attribute name of selector, what using ul element in dom structure close NG-ZORRO#3404

cipchk and others added 15 commits December 8, 2018 16:41

Merge pull request #1 from NG-ZORRO/master

f4e27e3

merge

Merge pull request #2 from NG-ZORRO/master

84b3c18

upgrade

Merge pull request #3 from NG-ZORRO/master

993ebea

upgrade

Merge pull request #4 from NG-ZORRO/master

9f6cc07

merge master

Merge pull request #5 from NG-ZORRO/master

e762917

merge master

Merge pull request #7 from NG-ZORRO/master

cb029b6

chore: merge master

Merge pull request #12 from NG-ZORRO/master

54953a0

chore: merge master Co-authored-by: Wendell <wendzhue@gmail.com> Co-authored-by: <coderpoet@outlook.com> Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com> Co-authored-by: Freax <huangyanxiong2013@gmail.com>

Merge pull request #14 from NG-ZORRO/master

29efbb9

chore: merge master Co-authored-by: Hsuan Lee <HsuanGM@gmail.com> Co-authored-by: Ethan Zhao <zdpluto@gmail.com> Co-authored-by: Wendell <wendzhue@gmail.com>

Merge pull request #15 from NG-ZORRO/master

9a89e07

chore: merge master Co-authored-by: <kekehao1212@outlook.com> Co-authored-by: <33472860+ng-zorro-bot@users.noreply.github.com>

refactor(module:list): refactor list component

3bda636

- limited by #3406, muse be wait for the #3406 merged - fix misplacement in vertical layout #3404 - add `nzNoFlex` property in nz-list-item - support attribute name of selector, what using ul element in dom structure

cipchk and others added 2 commits June 16, 2019 12:01

chore: merge master

e038f25

cipchk changed the title ~~WIP(module:list): refactor list component~~ refactor(module:list): refactor list component Jun 16, 2019

vthinkxie merged commit 65ce53c into NG-ZORRO:master Jun 21, 2019

pr-triage bot added the PR: merged label Jun 21, 2019

weekly-digest bot mentioned this pull request Jun 23, 2019

Weekly Digest (16 June, 2019 - 23 June, 2019) #3630

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(module:list): refactor list component #3422

refactor(module:list): refactor list component #3422

cipchk commented May 8, 2019

codecov bot commented May 8, 2019 •

edited

Loading

netlify bot commented Jun 16, 2019

refactor(module:list): refactor list component #3422

refactor(module:list): refactor list component #3422

Conversation

cipchk commented May 8, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

codecov bot commented May 8, 2019 • edited Loading

Codecov Report

netlify bot commented Jun 16, 2019

codecov bot commented May 8, 2019 •

edited

Loading