chore: bump to Angular 8.0.0 #3529

hsuanxyz · 2019-06-03T16:37:49Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: #3514

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

netlify · 2019-06-03T16:52:42Z

Deploy preview for ng-zorro-master ready!

Built with commit afe6cd4

https://deploy-preview-3529--ng-zorro-master.netlify.com

codecov · 2019-06-03T17:00:03Z

Codecov Report

Merging #3529 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3529      +/-   ##
==========================================
+ Coverage   95.67%   95.69%   +0.02%     
==========================================
  Files         690      690              
  Lines       13692    13692              
  Branches     1824     1824              
==========================================
+ Hits        13100    13103       +3     
  Misses        201      201              
+ Partials      391      388       -3

Impacted Files	Coverage Δ
components/core/tree/nz-tree-base.service.ts	`94.66% <ø> (ø)`	⬆️
components/empty/nz-empty.component.ts	`100% <ø> (ø)`	⬆️
components/calendar/nz-calendar.component.ts	`97.76% <ø> (ø)`	⬆️
components/tree/nz-tree.component.ts	`98.59% <100%> (ø)`	⬆️
components/drawer/nz-drawer.component.ts	`96.49% <100%> (-0.03%)`	⬇️
components/menu/nz-submenu.component.ts	`100% <100%> (ø)`	⬆️
components/popover/nz-popover.component.ts	`100% <100%> (ø)`	⬆️
components/comment/nz-comment-cells.ts	`95.65% <100%> (+0.19%)`	⬆️
components/upload/nz-upload.component.ts	`99.28% <100%> (ø)`	⬆️
components/select/nz-option-container.component.ts	`95.34% <100%> (ø)`	⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690692...cb69950. Read the comment docs.

netlify · 2019-06-03T17:07:10Z

Deploy preview for ng-zorro-master ready!

Built with commit cb69950

https://deploy-preview-3529--ng-zorro-master.netlify.com

wzhudev

Cheers!

test: fix test docs: update docs

lppedd · 2019-06-10T07:43:03Z

I would suggest waiting for 8.1 before merging. The first beta already fixed a lot of bugs.

vthinkxie · 2019-06-11T07:09:20Z

I would suggest waiting for 8.1 before merging. The first beta already fixed a lot of bugs.

yes, we will try to release ng-zorro-antd 8.0 after angular 8.1 released

vthinkxie · 2019-06-11T07:25:22Z

components/button/nz-button.component.ts

@@ -59,7 +59,7 @@ export class NzButtonComponent implements AfterContentInit, OnInit, OnDestroy, O
  readonly el: HTMLElement = this.elementRef.nativeElement;
  private iconElement: HTMLElement;
  private iconOnly = false;
-  @ViewChild('contentElement') contentElement: ElementRef;
+  @ViewChild('contentElement', { static: true }) contentElement: ElementRef;


is static true required here

vthinkxie

LGTM

lppedd · 2019-06-12T17:44:45Z

See this document for Ivy breaking changes, so that you might have a better overview of the things to change in the future : )
https://docs.google.com/document/d/1Dije0AsJ0PxL3NaeNPxpYDeapj30b_QC0xfeIvIIzgg/preview

* chore: bump to Angular 8.0.0 test: fix test docs: update docs * test: fix test * fix(module:descriptions): add static flag for v8

hsuanxyz force-pushed the v8 branch from afe6cd4 to c309118 Compare June 3, 2019 16:41

wzhudev approved these changes Jun 4, 2019

View reviewed changes

hsuanxyz added 2 commits June 6, 2019 10:34

chore: bump to Angular 8.0.0

81dd8c6

test: fix test docs: update docs

test: fix test

415e3ab

hsuanxyz force-pushed the v8 branch from 202bd62 to 415e3ab Compare June 6, 2019 02:35

fix(module:descriptions): add static flag for v8

cb69950

weekly-digest bot mentioned this pull request Jun 9, 2019

Weekly Digest (2 June, 2019 - 9 June, 2019) #3548

Closed

vthinkxie reviewed Jun 11, 2019

View reviewed changes

vthinkxie approved these changes Jun 11, 2019

View reviewed changes

vthinkxie merged commit 43aeaeb into NG-ZORRO:master Jun 11, 2019

weekly-digest bot mentioned this pull request Jun 16, 2019

Weekly Digest (9 June, 2019 - 16 June, 2019) #3582

Closed

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020

chore: bump to Angular 8.0.0 (NG-ZORRO#3529)

03b56eb

* chore: bump to Angular 8.0.0 test: fix test docs: update docs * test: fix test * fix(module:descriptions): add static flag for v8

hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020

chore: bump to Angular 8.0.0 (NG-ZORRO#3529)

7eec880

* chore: bump to Angular 8.0.0 test: fix test docs: update docs * test: fix test * fix(module:descriptions): add static flag for v8

hsuanxyz deleted the v8 branch August 5, 2020 02:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump to Angular 8.0.0 #3529

chore: bump to Angular 8.0.0 #3529

hsuanxyz commented Jun 3, 2019 •

edited

Loading

netlify bot commented Jun 3, 2019

codecov bot commented Jun 3, 2019 •

edited

Loading

netlify bot commented Jun 3, 2019 •

edited

Loading

wzhudev left a comment

lppedd commented Jun 10, 2019 •

edited

Loading

vthinkxie commented Jun 11, 2019

vthinkxie Jun 11, 2019

vthinkxie left a comment

lppedd commented Jun 12, 2019

chore: bump to Angular 8.0.0 #3529

chore: bump to Angular 8.0.0 #3529

Conversation

hsuanxyz commented Jun 3, 2019 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

netlify bot commented Jun 3, 2019

codecov bot commented Jun 3, 2019 • edited Loading

Codecov Report

netlify bot commented Jun 3, 2019 • edited Loading

wzhudev left a comment

Choose a reason for hiding this comment

lppedd commented Jun 10, 2019 • edited Loading

vthinkxie commented Jun 11, 2019

vthinkxie Jun 11, 2019

Choose a reason for hiding this comment

vthinkxie left a comment

Choose a reason for hiding this comment

lppedd commented Jun 12, 2019

hsuanxyz commented Jun 3, 2019 •

edited

Loading

codecov bot commented Jun 3, 2019 •

edited

Loading

netlify bot commented Jun 3, 2019 •

edited

Loading

lppedd commented Jun 10, 2019 •

edited

Loading