Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): disable wave animation when the type is link #3545

Merged
merged 2 commits into from
Jun 14, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jun 6, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jun 6, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d0250b8

https://deploy-preview-3545--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #3545 into master will increase coverage by 0.04%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
+ Coverage   95.67%   95.72%   +0.04%     
==========================================
  Files         690      690              
  Lines       13692    13701       +9     
  Branches     1824     1826       +2     
==========================================
+ Hits        13100    13115      +15     
+ Misses        201      198       -3     
+ Partials      391      388       -3
Impacted Files Coverage Δ
components/core/wave/nz-wave-renderer.ts 88.23% <100%> (+0.35%) ⬆️
components/button/nz-button.component.ts 94.36% <100%> (+0.24%) ⬆️
components/core/wave/nz-wave.directive.ts 97.72% <88.88%> (+12.72%) ⬆️
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690692...d0250b8. Read the comment docs.

@vthinkxie vthinkxie merged commit ccb68ae into NG-ZORRO:master Jun 14, 2019
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Jun 14, 2019
…ZORRO#3545)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close NG-ZORRO#3546
vthinkxie pushed a commit that referenced this pull request Jun 14, 2019
…) (#3572)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close #3546
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ZORRO#3545)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close NG-ZORRO#3546
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ZORRO#3545)

* fix(module:button): disable wave animation when the type is link

* test(module:core): fix wave test
close NG-ZORRO#3546
@hsuanxyz hsuanxyz deleted the fix/button-wave branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants