Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support angular 8.0 #3622

Merged
merged 6 commits into from
Jun 22, 2019
Merged

chore: support angular 8.0 #3622

merged 6 commits into from
Jun 22, 2019

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jun 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 80b2d2c

https://deploy-preview-3622--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #3622 into master will increase coverage by <.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3622      +/-   ##
==========================================
+ Coverage   95.45%   95.46%   +<.01%     
==========================================
  Files         685      685              
  Lines       14042    14056      +14     
  Branches     1865     1871       +6     
==========================================
+ Hits        13404    13418      +14     
+ Misses        231      230       -1     
- Partials      407      408       +1
Impacted Files Coverage Δ
...mponents/select/nz-select-top-control.component.ts 100% <ø> (ø) ⬆️
...mponents/input-number/nz-input-number.component.ts 97.6% <100%> (+0.01%) ⬆️
components/select/nz-select.component.ts 96.93% <100%> (+0.01%) ⬆️
components/select/nz-select.service.ts 85.77% <100%> (+0.06%) ⬆️
components/core/addon/string_template_outlet.ts 67.24% <84.61%> (+7.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c82f26...de7f91b. Read the comment docs.

@netlify
Copy link

netlify bot commented Jun 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit de7f91b

https://deploy-preview-3622--ng-zorro-master.netlify.com

@vthinkxie vthinkxie merged commit 3ca816d into NG-ZORRO:master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant