-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:dropdown): allow backdrop to be disabled #3769
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 5d106ca |
Codecov Report
@@ Coverage Diff @@
## master #3769 +/- ##
==========================================
+ Coverage 95.38% 95.38% +<.01%
==========================================
Files 706 706
Lines 14506 14508 +2
Branches 1913 1914 +1
==========================================
+ Hits 13836 13839 +3
Misses 243 243
+ Partials 427 426 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR
@vthinkxie my pleasure. Fixed documentation. Thanks! |
Needs someone that translate the documentation to Chinese, I'm afraid I cannot 😄
See "current behavior" for explanation.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the backdrop is enforced when using
trigger = 'click'
.This causes usability problems when used in conjunction, for example, with a custom table filter.
What is the new behavior?
The backdrop can be disabled by setting
nzBackdrop = false
.Does this PR introduce a breaking change?
Other information