fix(module:date-picker): keep the time value while clicking date #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit da5e3fd |
Codecov Report
@@ Coverage Diff @@
## master #3911 +/- ##
==========================================
+ Coverage 95.24% 95.24% +<.01%
==========================================
Files 726 726
Lines 14672 14672
Branches 1910 1909 -1
==========================================
+ Hits 13974 13975 +1
Misses 260 260
+ Partials 438 437 -1
Continue to review full report at Codecov.
|
wzhudev
reviewed
Aug 2, 2019
| .setMonth(value.getMonth()) | ||
| .setDate(value.getDate()); | ||
|
|
||
| if (this.value !== newValue) { |
There was a problem hiding this comment.
CandyDate 的 setxxx 方法返回的都是新的实例，判断总会是 false
wenqi73
force-pushed
the
fix-datepicker-time
branch
from
3309a7e to
da5e3fd
Compare
|
This should be a fix. |
wenqi73
changed the title
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
…ZORRO#3911) * chore(module:date-picker): keep the time value while clicking date * chore: delete jugdement
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…ZORRO#3911) * chore(module:date-picker): keep the time value while clicking date * chore: delete jugdement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2576, close #1949
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information