Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: table small sticky style #4036

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Aug 21, 2019

Reverts #3849
It will cause another issue of small table hover style. Ant design has fixed small sticky style (0608f45#diff-6f1e26fcf688fcefd89a8725673c03abR78)

@vthinkxie
Copy link
Member

should add hover style, not just remove them, the sticky is not the same as react version.

@netlify
Copy link

netlify bot commented Aug 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 23e158c

https://deploy-preview-4036--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (ccb6972) to head (23e158c).
Report is 1773 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4036      +/-   ##
==========================================
+ Coverage   92.38%   92.43%   +0.04%     
==========================================
  Files         506      506              
  Lines       10749    10749              
  Branches     1942     1942              
==========================================
+ Hits         9931     9936       +5     
+ Misses        405      400       -5     
  Partials      413      413              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenqi73 wenqi73 requested a review from vthinkxie August 23, 2019 08:06
@simplejason simplejason self-requested a review August 26, 2019 03:17
@simplejason simplejason merged commit 2b8150c into master Aug 26, 2019
@wenqi73 wenqi73 deleted the revert-3849-fix-table-small-style branch August 26, 2019 09:19
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants