feat(module:steps): support navigation type and nzDisable nzSubtitle #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit cb6acb4 |
hsuanxyz
force-pushed
the
feat/steps-navigation
branch
from
6c078a7 to
16c2bec
Compare
Codecov Report
@@ Coverage Diff @@
## master #4064 +/- ##
========================================
- Coverage 92.4% 92.3% -0.1%
========================================
Files 506 514 +8
Lines 10758 10803 +45
Branches 1940 1954 +14
========================================
+ Hits 9941 9972 +31
- Misses 402 412 +10
- Partials 415 419 +4
Continue to review full report at Codecov.
|
hsuanxyz
force-pushed
the
feat/steps-navigation
branch
from
fc92c20 to
dcee746
Compare
wzhudev
reviewed
Sep 6, 2019
| @@ -18,7 +18,7 @@ import { Component } from '@angular/core'; | |||
| }) | |||
| export class NzDemoStepsClickableComponent { | |||
| index = 0; | |||
|
|
|||
| disable = false; | |||
There was a problem hiding this comment.
清理一下 demo 好了，这个属性没看到有更改，而且也不是 true。
或者改成 true 然后用例里反过来测。
wzhudev
reviewed
Sep 6, 2019
wzhudev
approved these changes
Sep 9, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
…G-ZORRO#4064) * feat(module:steps): support navigation type and nzDisable nzSubtitle close NG-ZORRO#3931 * docs(module:steps): update docs
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…G-ZORRO#4064) * feat(module:steps): support navigation type and nzDisable nzSubtitle close NG-ZORRO#3931 * docs(module:steps): update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3931
What is the new behavior?
Does this PR introduce a breaking change?
Other information