Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft: validate global config works with Ivy #4086

Closed
wants to merge 7 commits into from
Closed

draft: validate global config works with Ivy #4086

wants to merge 7 commits into from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 30, 2019 •
edited
Loading

This pr is just a proof that #3613 & #4042 can work together.

⚠️⚠️⚠️ DO NOT MERGE THIS

屏幕快照 2019-08-30 10 58 04

{ 
  provide: NZ_CONFIG, useValue: {
    icon: { nzTwotoneColor: '#1890ff' },
    button: { nzSize: 'large' }
  }
}

@pr-triage pr-triage bot added the PR: draft label Aug 30, 2019
@auto-assign auto-assign bot requested a review from simplejason August 30, 2019 03:00
@NG-ZORRO NG-ZORRO locked as resolved and limited conversation to collaborators Aug 30, 2019
@wzhudev wzhudev removed the request for review from simplejason August 30, 2019 03:02
@wzhudev
Copy link
Member Author

wzhudev commented Sep 4, 2019

Closed since #4042 is merged.

@wzhudev wzhudev closed this Sep 4, 2019
@wzhudev wzhudev deleted the global-config-with-ivy branch September 4, 2019 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz hsuanxyz will be requested when the pull request is marked ready for review hsuanxyz is a code owner

@simplejason simplejason Awaiting requested review from simplejason simplejason will be requested when the pull request is marked ready for review simplejason is a code owner

@Ricbet Ricbet Awaiting requested review from Ricbet Ricbet will be requested when the pull request is marked ready for review Ricbet is a code owner

@danranVm danranVm Awaiting requested review from danranVm danranVm will be requested when the pull request is marked ready for review danranVm is a code owner

@vthinkxie vthinkxie Awaiting requested review from vthinkxie vthinkxie will be requested when the pull request is marked ready for review vthinkxie is a code owner

@wenqi73 wenqi73 Awaiting requested review from wenqi73 wenqi73 will be requested when the pull request is marked ready for review wenqi73 is a code owner

@Laffery Laffery Awaiting requested review from Laffery Laffery will be requested when the pull request is marked ready for review Laffery is a code owner

@cipchk cipchk Awaiting requested review from cipchk cipchk will be requested when the pull request is marked ready for review cipchk is a code owner

Assignees
No one assigned
Labels
PR: draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wzhudev @wenqi73 @hsuanxyz @simplejason