Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:i18n): added property missing in ar_EG #4165

Merged
merged 3 commits into from
Sep 20, 2019
Merged

fix(module:i18n): added property missing in ar_EG #4165

merged 3 commits into from
Sep 20, 2019

Conversation

Abdullah700
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4159

What is the new behavior?

all localization for ar_EG should be displayed in arabic

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Sep 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 52bfb29

https://deploy-preview-4165--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #4165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4165   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         517      517           
  Lines       10961    10961           
  Branches     1985     1985           
=======================================
  Hits        10114    10114           
  Misses        422      422           
  Partials      425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1e496...52bfb29. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Sep 16, 2019

@Abdullah700 Great work! Thank you!

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 36a5ebb into NG-ZORRO:master Sep 20, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fixed missing arabic properites

* fix(module:i18n): added property missing in ar_EG
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fixed missing arabic properites

* fix(module:i18n): added property missing in ar_EG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants