refactor(module:date-picker): move class control to host #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit a5b60ff |
wenqi73
force-pushed
the
date-picker-style1
branch
from
cf84758 to
a95ece5
Compare
wenqi73
requested review from
hsuanxyz
and removed request for
cipchk and
wzhudev
Codecov Report
@@ Coverage Diff @@
## master #4207 +/- ##
=========================================
- Coverage 92.22% 92.2% -0.02%
=========================================
Files 522 521 -1
Lines 11107 11018 -89
Branches 2018 1997 -21
=========================================
- Hits 10243 10159 -84
+ Misses 436 429 -7
- Partials 428 430 +2
Continue to review full report at Codecov.
|
wzhudev
reviewed
Oct 14, 2019
Comment on lines
+1
to
+28
| /** | ||
| * @license | ||
| * Copyright Alibaba.com All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/LICENSE | ||
| */ | ||
|
|
||
| import { DebugElement } from '@angular/core'; | ||
| import { By } from '@angular/platform-browser'; | ||
| import { NzPickerComponent } from './picker.component'; | ||
|
|
||
| export function getPickerAbstract<T = HTMLElement>(debugElement: DebugElement): T { | ||
| return debugElement.query(By.css('.ant-calendar-picker')).nativeElement; | ||
| } | ||
|
|
||
| export function getPickerTrigger(debugElement: DebugElement): HTMLElement { | ||
| return debugElement.query(By.directive(NzPickerComponent)).nativeElement; | ||
| } | ||
|
|
||
| export function getPickerInput(debugElement: DebugElement): HTMLInputElement { | ||
| return debugElement.query(By.css('div .ant-calendar-picker-input')).nativeElement as HTMLInputElement; | ||
| } | ||
|
|
||
| export function getRangePickerLeftInput(debugElement: DebugElement): HTMLInputElement { | ||
| return debugElement.queryAll(By.css('div input.ant-calendar-range-picker-input'))[0] | ||
| .nativeElement as HTMLInputElement; | ||
| } |
| @@ -168,6 +193,8 @@ export abstract class AbstractPickerComponent implements OnInit, OnChanges, OnDe | |||
| this.cdr.markForCheck(); | |||
| } | |||
|
|
|||
| updateHostClass(): void {} | |||
hsuanxyz
reviewed
Oct 14, 2019
Comment on lines
+11
to
+13
| [ngClass]="nzClassName" | ||
| [style]="nzStyle" | ||
| [ngStyle]="pickerStyle" |
There was a problem hiding this comment.
者几个属性应该是在 host 上生效的，再确认一下 react 那边
There was a problem hiding this comment.
可以考虑废弃掉，让用户直接使用 ngClass 和 ngStyle 或者原生属性。 不过可能会有 break change
|
@wendzhue @hsuanxyz 要不 9.0.0 合？DOM 结构变了对用 css 的用户来说确实有 break change。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1614
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
新增：