-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:*): fix style error with 3.23.6 #4258
Conversation
Deploy preview for ng-zorro-master ready! Built with commit d19c678 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breadcrumb 结构有变化
<div class="ant-breadcrumb">
<span>
<a class="ant-breadcrumb-link">
<i>...</i>
<span>Application List</span>
</a>
<span class="ant-breadcrumb-separator">/</span>
</span>
</div>
<nz-breadcrumb class="ant-breadcrumb">
<nz-breadcrumb-item>
<span class="ant-breadcrumb-link">
<a>
<i>...</i>
<span>Application List</span>
</a>
</span>
<span class="ant-breadcrumb-separator">/</span>
</nz-breadcrumb-item>
</nz-breadcrumb>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下拉按钮 class 不一样
https://ant.design/components/dropdown-cn/#components-dropdown-demo-dropdown-button
- <nz-button-group class="ant-btn-group">
+ <nz-button-group class="ant-btn-group ant-dropdown-button">
<button class="ant-btn ant-btn-default"><span>DropDown</span></button>
- <button class="ant-dropdown-trigger ant-btn ant-btn-default ant-btn-icon-only">
+ <button class="ant-dropdown-trigger ant-btn ant-btn-default">
<i>...</i>
- <span style="display: none;"></span>
</button>
</nz-button-group>
Codecov Report
@@ Coverage Diff @@
## master #4258 +/- ##
==========================================
- Coverage 92.33% 92.28% -0.06%
==========================================
Files 520 520
Lines 10965 10977 +12
Branches 1984 1988 +4
==========================================
+ Hits 10125 10130 +5
- Misses 418 422 +4
- Partials 422 425 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ngIf 应该在 header 上面,否则会有一个空的左边距
- <div class="ant-skeleton-header">
+ <div class="ant-skeleton-header" *ngIf="!!nzAvatar">
<span
- *ngIf="!!nzAvatar"
class="ant-skeleton-avatar"
[class.ant-skeleton-avatar-lg]="avatar.size === 'large'"
[class.ant-skeleton-avatar-sm]="avatar.size === 'small'"
[class.ant-skeleton-avatar-circle]="avatar.shape === 'circle'"
[class.ant-skeleton-avatar-square]="avatar.shape === 'square'">
</span>
</div>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information