docs: explain how to submit TemplateRef instances in global config #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit dc53a65 |
Codecov Report
@@ Coverage Diff @@
## master #4321 +/- ##
==========================================
- Coverage 92.16% 92.15% -0.01%
==========================================
Files 520 520
Lines 11016 11016
Branches 1997 1997
==========================================
- Hits 10153 10152 -1
Misses 431 431
- Partials 432 433 +1
Continue to review full report at Codecov.
|
wzhudev
reviewed
Oct 20, 2019
docs/global-config.en-US.md
Outdated
| @@ -35,7 +35,85 @@ export class AppModule {} | |||
|
|
|||
| These global configuration would be injected into a service named `NzConfigService` and gets stored. | |||
|
|
|||
| ## Dynamically Chaing Configs | |||
| ### Templates | |||
There was a problem hiding this comment.
This title could be more explicit. Something like "Provide Templates in Global Configutation".
There was a problem hiding this comment.
@wendzhue I've choosen "Provide Template Instances", as we already are in global configuration scope and it's sub-sub-sub header. Is it ok?
wzhudev
reviewed
Oct 20, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4318
PR Checklist
Please check if your PR fulfills the following requirements:
Tests for the changes have been added (for bug fixes / features)PR Type
What kind of change does this PR introduce?
What is the current behavior?
See issue.
Issue Number: #4318
Plus fixed a typo: Dynamically
ChaingChaining ConfigurationsDoes this PR introduce a breaking change?