Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): nzDefaultOpenValue not work in time panel #4357

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Oct 28, 2019

Close #4331

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Oct 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 72f606c

https://deploy-preview-4357--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #4357 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4357      +/-   ##
==========================================
- Coverage    92.2%   92.11%   -0.09%     
==========================================
  Files         520      521       +1     
  Lines       11039    11078      +39     
  Branches     1997     2010      +13     
==========================================
+ Hits        10178    10205      +27     
- Misses        429      446      +17     
+ Partials      432      427       -5
Impacted Files Coverage Δ
...ts/date-picker/lib/popups/inner-popup.component.ts 95.45% <100%> (-0.38%) ⬇️
components/calendar/date-table.component.ts 92.78% <100%> (+0.07%) ⬆️
...e-picker/lib/calendar/calendar-header.component.ts 95.38% <100%> (+0.07%) ⬆️
...mponents/carousel/strategies/transform-strategy.ts 84.81% <0%> (-10.13%) ⬇️
components/core/util/dom.ts 85.71% <0%> (-3.18%) ⬇️
components/core/tree/nz-tree-base.service.ts 93.62% <0%> (-0.4%) ⬇️
components/carousel/nz-carousel.component.ts 93.12% <0%> (-0.12%) ⬇️
components/tree/nz-tree.component.ts 97.74% <0%> (-0.07%) ⬇️
components/page-header/nz-page-header.component.ts 100% <0%> (ø) ⬆️
components/core/config/config.ts 100% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bae5e...72f606c. Read the comment docs.

@hsuanxyz hsuanxyz changed the title fix(module:date-picker): nzDefaultOpenValue should work if ngModel is null fix(module:date-picker): nzDefaultOpenValue not work in time panel Nov 8, 2019
@hsuanxyz hsuanxyz merged commit dfa3d39 into NG-ZORRO:master Nov 8, 2019
@wenqi73 wenqi73 deleted the fix-nzDefaultOpenValue branch April 2, 2020 10:09
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…G-ZORRO#4357)

* fix(module:date-picker): `nzDefaultOpenValue` not work

* fix: test

* chore: do null check in lower component

Close NG-ZORRO#4331
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…G-ZORRO#4357)

* fix(module:date-picker): `nzDefaultOpenValue` not work

* fix: test

* chore: do null check in lower component

Close NG-ZORRO#4331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-date-picker设置[nzShowTime]的nzDefaultOpenValue属性无效
3 participants