Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): default tags incorrect in strictly mode #4368

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Nov 1, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4364

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Nov 1, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 7f23338

https://deploy-preview-4368--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz force-pushed the fix/tree-select-default branch from 54af32e to 7f23338 Compare November 1, 2019 09:05
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #4368 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4368      +/-   ##
==========================================
- Coverage    92.2%   92.19%   -0.01%     
==========================================
  Files         520      520              
  Lines       11039    11036       -3     
  Branches     1997     1997              
==========================================
- Hits        10178    10175       -3     
  Misses        429      429              
  Partials      432      432
Impacted Files Coverage Δ
components/tree/nz-tree.component.ts 97.74% <100%> (-0.07%) ⬇️
components/tree-select/nz-tree-select.component.ts 98.93% <100%> (ø) ⬆️
components/core/tree/nz-tree-base.service.ts 93.62% <0%> (-0.4%) ⬇️
components/typography/nz-typography.component.ts 98.97% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12111e5...7f23338. Read the comment docs.

@hsuanxyz hsuanxyz requested review from simplejason and removed request for wzhudev November 1, 2019 10:06
@hsuanxyz hsuanxyz merged commit a6547a0 into NG-ZORRO:master Nov 7, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the fix/tree-select-default branch August 5, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants