-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:select): prevent hidden options from being selected #4382
fix(module:select): prevent hidden options from being selected #4382
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 0227d23 |
Codecov Report
@@ Coverage Diff @@
## master #4382 +/- ##
==========================================
+ Coverage 92.2% 92.31% +0.11%
==========================================
Files 520 520
Lines 11039 11040 +1
Branches 1997 1997
==========================================
+ Hits 10178 10192 +14
+ Misses 429 419 -10
+ Partials 432 429 -3
Continue to review full report at Codecov.
|
Hi @QichenZhu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…RRO#4382) * fix(module:select): prevent hidden options from being selected (NG-ZORRO#4377) * fix(module:select): add test cases * fix(module:select): fix test cases close NG-ZORRO#4377
…RRO#4382) * fix(module:select): prevent hidden options from being selected (NG-ZORRO#4377) * fix(module:select): add test cases * fix(module:select): fix test cases close NG-ZORRO#4377
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4377
What is the new behavior?
Hidden options cannot be selected.
Does this PR introduce a breaking change?
Other information