Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): prevent hidden options from being selected #4382

Conversation

QichenZhu
Copy link
Contributor

@QichenZhu QichenZhu commented Nov 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4377

What is the new behavior?

Hidden options cannot be selected.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Nov 5, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0227d23

https://deploy-preview-4382--ng-zorro-master.netlify.com

@QichenZhu QichenZhu changed the title fix(module:select): prevent hidden options from being selected (#4377) fix(module:select): prevent hidden options from being selected Nov 5, 2019
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #4382 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4382      +/-   ##
==========================================
+ Coverage    92.2%   92.31%   +0.11%     
==========================================
  Files         520      520              
  Lines       11039    11040       +1     
  Branches     1997     1997              
==========================================
+ Hits        10178    10192      +14     
+ Misses        429      419      -10     
+ Partials      432      429       -3
Impacted Files Coverage Δ
components/select/nz-select.service.ts 86.22% <100%> (+2.63%) ⬆️
components/core/addon/string_template_outlet.ts 84% <0%> (+16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3868e...0227d23. Read the comment docs.

@vthinkxie
Copy link
Member

Hi @QichenZhu
thanks a lot for your pr
could you add some test cases to pass the CI?

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chensimeng chensimeng merged commit cf22133 into NG-ZORRO:master Nov 8, 2019
@QichenZhu QichenZhu deleted the fix-module-select-prevent-hidden-options-from-being-selected-4377 branch November 8, 2019 11:28
@QichenZhu QichenZhu restored the fix-module-select-prevent-hidden-options-from-being-selected-4377 branch November 8, 2019 11:30
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…RRO#4382)

* fix(module:select): prevent hidden options from being selected (NG-ZORRO#4377)

* fix(module:select): add test cases

* fix(module:select): fix test cases

close NG-ZORRO#4377
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…RRO#4382)

* fix(module:select): prevent hidden options from being selected (NG-ZORRO#4377)

* fix(module:select): add test cases

* fix(module:select): fix test cases

close NG-ZORRO#4377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants