Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep list of Bank Holidays up to date #8

Open
joshpencheon opened this issue Jul 27, 2018 · 2 comments
Open

Keep list of Bank Holidays up to date #8

joshpencheon opened this issue Jul 27, 2018 · 2 comments

Comments

@joshpencheon
Copy link
Contributor

The WorkingDays concerns tracks public holidays (for England/Wales), but needs manual updating. As a result, it has fallen stale.

We should make use of https://www.gov.uk/bank-holidays/england-and-wales.json, perhaps baking the cache at rake build time. We can't presume to have internet connectivity once ndr_support is being used.

@timgentry
Copy link
Contributor

@joshpencheon regardless of the solution, we could add a test that goes and gets https://www.gov.uk/bank-holidays/england-and-wales.json and assert that all the returned bank holidays are considered holidays.

@timgentry
Copy link
Contributor

If we did use the holidays gem I think we would use the :gb_eaw region

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants