Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAC S3 Resource Update #6

Merged
merged 1 commit into from
Mar 21, 2022
Merged

IAC S3 Resource Update #6

merged 1 commit into from
Mar 21, 2022

Conversation

ohaikthxbai
Copy link
Contributor

@ohaikthxbai ohaikthxbai commented Mar 21, 2022

Overview

This PR covers an IAC update to the AWS S3 Bucket resource based on the terraform/aws version 4.0.x:
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v4.0.0
Referring to the following line:

resource/aws_s3_bucket: The acl and grant arguments have been deprecated and are now read-only. Use the aws_s3_bucket_acl resource instead. (hashicorp/terraform-provider-aws#22537)

Note

Also, not sure if this should have gone into 'develop' first, then into 'stable', so please correct me if I'm wrong here.

Copy link
Member

@nie7321 nie7321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for maintaining this!

@ohaikthxbai ohaikthxbai merged commit 8cddd80 into stable Mar 21, 2022
@ohaikthxbai ohaikthxbai deleted the s3-acl-update branch March 21, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants